For batch mode tests, make sure we read stderr in case of a crash.

tools/testing/dart/test_runner.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for executing tests.
  *
  * This module includes:
  * - Managing parallel execution of tests, including timeout checks.
  * - Evaluating the output of each test as pass/fail/crash/timeout.
@@ skipping 583 matching lines @@
     timedOut = true;
     process.kill();
   }
 }
 
 class BatchRunnerProcess {
   String _executable;
   List<String> _batchArguments;
 
   Process _process;
+  bool _processDone = true;
   StringInputStream _stdoutStream;
   StringInputStream _stderrStream;
 
   TestCase _currentTest;
   List<String> _testStdout;
   List<String> _testStderr;
   bool _stdoutDrained = false;
   bool _stderrDrained = false;
+  String _status;
   Date _startTime;
   Timer _timer;
 
   bool _isWebDriver;
 
   BatchRunnerProcess(TestCase testCase) {
     _executable = testCase.commands.last().executable;
     _batchArguments = testCase.batchRunnerArguments;
     _isWebDriver = testCase.usesWebDriver;
   }
 
   bool get active() => _currentTest != null;
 
   void startTest(TestCase testCase) {
     _currentTest = testCase;
-    if (_process === null) {
+    if (_processDone) {
       // Start process if not yet started.
       _executable = testCase.commands.last().executable;
       _startProcess(() {
         doStartTest(testCase);
       });
     } else if (testCase.commands.last().executable != _executable) {
       // Restart this runner with the right executable for this test
       // if needed.
       _executable = testCase.commands.last().executable;
       _batchArguments = testCase.batchRunnerArguments;
@@ skipping 48 matching lines @@
     return Strings.join(arguments, ' ') + '\n';
   }
 
   void _testCompleted() {
     var test = _currentTest;
     _currentTest = null;
     test.completed();
   }
 
   int _reportResult(String output) {
-    _stdoutDrained = true;
     // output = '>>> TEST {PASS, FAIL, OK, CRASH, FAIL, TIMEOUT}'
     var outcome = output.split(" ")[2];
     var exitCode = 0;
     if (outcome == "CRASH") exitCode = -10;
     if (outcome == "FAIL" || outcome == "TIMEOUT") exitCode = 1;
     new TestOutput.fromCase(_currentTest, exitCode, outcome == "TIMEOUT",
                    _testStdout, _testStderr, new Date.now().difference(_startTime));
     // Move on when both stdout and stderr has been drained. If the test
     // crashed, we restarted the process and therefore do not attempt to
     // drain stderr.
-    if (_stderrDrained || (_currentTest.output.hasCrashed)) _testCompleted();
-  }
-
-  void _stderrDone() {
-    _stderrDrained = true;
-    // Move on when both stdout and stderr has been drained.
-    if (_stdoutDrained) _testCompleted();
+    if (_stderrDrained) _testCompleted();
   }
 
   Function _readStdout(StringInputStream stream, List<String> buffer) {
     return () {
       var status;
       var line = stream.readLine();
       while (line != null) {
         if (line.startsWith('>>> TEST')) {
           status = line;
+          _stdoutDrained = true;
         } else if (line.startsWith('>>> BATCH START')) {
           // ignore
         } else if (line.startsWith('>>> ')) {
           throw new Exception('Unexpected command from dartc batch runner.');
         } else {
           buffer.add(line);
         }
         line = stream.readLine();
       }
       if (status != null) {
         _timer.cancel();
-        // For crashing processes, let the exit handler deal with it.
-        if (!status.contains("CRASH")) {
+        this._status = status;
+        if (_stderrDrained) {
           _reportResult(status);
+          if (_processDone) {
+            _startProcess();
+          }
         }
       }
     };
   }
 
   Function _readStderr(StringInputStream stream, List<String> buffer) {
     return () {
       var line = stream.readLine();
       while (line != null) {
+        var status;
         if (line.startsWith('>>> EOF STDERR')) {
-          _stderrDone();
+          _stderrDrained = true;
+          if (_stdoutDrained) {
+            _reportResult(this._status);
+            if (_processDone) {
+              _startProcess();
+            }
+          }
         } else {
           buffer.add(line);
         }
         line = stream.readLine();
       }
     };
   }
 
   void _exitHandler(exitCode) {
     if (_timer != null) _timer.cancel();
     _process.close();
-    _startProcess(() {
-      _reportResult(">>> TEST CRASH");
-    });
+    _processDone = true;
+    if (_stdoutDrained && _stderrDrained) {
+      _startProcess();
+    }
   }
 
   void _timeoutHandler(ignore) {
     _process.onExit = (exitCode) {
       _process.close();
       _startProcess(() {
         _reportResult(">>> TEST TIMEOUT");
       });
     };
     _process.kill();
   }
 
-  void _startProcess(then) {
+  void _startProcess([then = null]) {
     _process = new Process.start(_executable, _batchArguments);
+    _processDone = false;
     _stdoutStream = new StringInputStream(_process.stdout);
     _stderrStream = new StringInputStream(_process.stderr);
     _testStdout = new List<String>();
     _testStderr = new List<String>();
     _stdoutDrained = false;
     _stderrDrained = false;
     _stdoutStream.onLine = _readStdout(_stdoutStream, _testStdout);
     _stderrStream.onLine = _readStderr(_stderrStream, _testStderr);
     _process.onExit = _exitHandler;
     _process.onStart = then;
@@ skipping 324 matching lines @@
         // the developer doesn't waste his or her time trying to fix a bunch of
         // tests that appear to be broken but were actually just flakes that
         // didn't get retried because there had already been one failure.
         bool allowRetry = _MAX_FAILED_NO_RETRY > _progress.numFailedTests;
         new RunningProcess(test, allowRetry, this).start();
       }
       _numProcesses++;
     }
   }
 }