Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4570)

Unified Diff: chrome/browser/mac/install_from_dmg.mm

Issue 9845017: Fix a few warnings that -Wnull-conversion of a future clang will complain about. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/mac/install_from_dmg.mm
diff --git a/chrome/browser/mac/install_from_dmg.mm b/chrome/browser/mac/install_from_dmg.mm
index ab1241e5b97602685ac7b947901f027bf33cc683..240c7a070230f7f38ea0aafabbab8367072aae50 100644
--- a/chrome/browser/mac/install_from_dmg.mm
+++ b/chrome/browser/mac/install_from_dmg.mm
@@ -82,10 +82,10 @@ io_service_t CopyHDIXDriveServiceForMedia(io_service_t media) {
&iterator_ref);
if (kr != KERN_SUCCESS) {
LOG(ERROR) << "IORegistryEntryCreateIterator: " << kr;
- return NULL;
+ return 0;
Mark Mentovai 2012/03/27 21:09:59 IO_OBJECT_NULL in this file too.
}
base::mac::ScopedIOObject<io_iterator_t> iterator(iterator_ref);
- iterator_ref = NULL;
+ iterator_ref = 0;
// Look at each of the ancestor services, beginning with the parent,
// iterating all the way up to the device tree's root. If any ancestor
@@ -102,7 +102,7 @@ io_service_t CopyHDIXDriveServiceForMedia(io_service_t media) {
}
// The media does not reside on a disk image.
- return NULL;
+ return 0;
}
// Given an io_service_t (expected to be of class IOMedia), determines whether
@@ -213,7 +213,7 @@ bool IsPathOnReadOnlyDiskImage(const char path[],
return false;
}
base::mac::ScopedIOObject<io_iterator_t> iterator(iterator_ref);
- iterator_ref = NULL;
+ iterator_ref = 0;
// There needs to be exactly one matching service.
base::mac::ScopedIOObject<io_service_t> media(IOIteratorNext(iterator));

Powered by Google App Engine
This is Rietveld 408576698