Fix a few warnings that -Wnull-conversion of a future clang will complain about.

Fix a few warnings that -Wnull-conversion of a future clang will complain about.

BUG=none
TEST=none
TBR=OWNERS
NOTRY=true

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129337

[Mark Mentovai, 2012-03-27 21:09:59]

Some data types provide their own symbolic constant to use in place of NULL;
these are better than 0.

http://codereview.chromium.org/9845017/diff/7001/base/mac/scoped_ioobject.h
File base/mac/scoped_ioobject.h (right):

http://codereview.chromium.org/9845017/diff/7001/base/mac/scoped_ioobject.h#n...
base/mac/scoped_ioobject.h:62: object_ = 0;
It would be proper to use IO_OBJECT_NULL here.

http://codereview.chromium.org/9845017/diff/7001/chrome/browser/mac/install_f...
File chrome/browser/mac/install_from_dmg.mm (right):

http://codereview.chromium.org/9845017/diff/7001/chrome/browser/mac/install_f...
chrome/browser/mac/install_from_dmg.mm:85: return 0;
IO_OBJECT_NULL in this file too.

http://codereview.chromium.org/9845017/diff/7001/crypto/cssm_init.cc
File crypto/cssm_init.cc (right):

http://codereview.chromium.org/9845017/diff/7001/crypto/cssm_init.cc#newcode53
crypto/cssm_init.cc:53: tp_loaded_(false), csp_handle_(0), cl_handle_(0),
tp_handle_(0) {
CSSM_INVALID_HANDLE

http://codereview.chromium.org/9845017/diff/7001/crypto/rsa_private_key_mac.cc
File crypto/rsa_private_key_mac.cc (right):

http://codereview.chromium.org/9845017/diff/7001/crypto/rsa_private_key_mac.c...
crypto/rsa_private_key_mac.cc:74: crtn =
CSSM_QueryKeySizeInBits(GetSharedCSPHandle(), 0, &key, &key_size);
CSSM_INVALID_HANDLE and again on line 136.

http://codereview.chromium.org/9845017/diff/7001/net/base/x509_util_mac.cc
File net/base/x509_util_mac.cc (right):

http://codereview.chromium.org/9845017/diff/7001/net/base/x509_util_mac.cc#ne...
net/base/x509_util_mac.cc:136: : cl_handle_(0),
CSSM_INVALID_HANDLE in this file.

[Nico, 2012-03-27 21:30:05]

Thanks, all done. Found (and used) names for null plugins and surfaces too.

[Mark Mentovai, 2012-03-27 21:43:42]

LGTM, except for one try bot-inspired comment.

http://codereview.chromium.org/9845017/diff/12001/ui/gfx/compositor/layer_uni...
File ui/gfx/compositor/layer_unittest.cc (right):

http://codereview.chromium.org/9845017/diff/12001/ui/gfx/compositor/layer_uni...
ui/gfx/compositor/layer_unittest.cc:369: new Compositor(this,
kNullAcceleratedWidget, gfx::Size(1000, 1000)));
The linux_chromeos try bot hated this. ui/gfx/native_widget_types.h may need to
be revised to contain a good constant for this on that platform.

[Nico, 2012-03-27 21:55:20]

thanks!

http://codereview.chromium.org/9845017/diff/12001/ui/gfx/compositor/layer_uni...
File ui/gfx/compositor/layer_unittest.cc (right):

http://codereview.chromium.org/9845017/diff/12001/ui/gfx/compositor/layer_uni...
ui/gfx/compositor/layer_unittest.cc:369: new Compositor(this,
kNullAcceleratedWidget, gfx::Size(1000, 1000)));
Hm, maybe cros needs an explicit gfx:: for some reason. Added that, let's see
what happens.

[commit-bot: I haz the power, 2012-03-27 22:49:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/9845017/15004

[commit-bot: I haz the power, 2012-03-27 22:49:43]

Presubmit check for 9845017-15004 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content/browser
    crypto
    webkit/plugins/npapi
    content/renderer
    webkit
    net
    ui/gfx/compositor

Presubmit checks took 1.7s to calculate.

[Nico, 2012-03-27 22:52:23]

sky, tony, eroman: OWNERS stamps.

[sky, 2012-03-27 22:55:21]

LGTM

[tony, 2012-03-27 22:56:28]

LGTM2

[commit-bot: I haz the power, 2012-03-27 22:57:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/9845017/15004

[commit-bot: I haz the power, 2012-03-27 23:31:22]

Try job failure for 9845017-15004 on win for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-03-27 23:45:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/9845017/15004

[commit-bot: I haz the power, 2012-03-28 00:03:03]

Try job failure for 9845017-15004 on win_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-03-28 01:33:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/9845017/15004

[commit-bot: I haz the power, 2012-03-28 01:35:54]

Change committed as 129337