chrome/browser/extensions/platform_app_browsertest.cc - Issue 9845003: Pass command line arguments onto platform apps which provide the right intent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/platform_app_browsertest.cc

Issue 9845003: Pass command line arguments onto platform apps which provide the right intent. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Use ScopedAllowIO to avoid race, don't check file existence, windows compile fix Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/extensions/platform_app_intent_dispatcher.h » ('j') | chrome/browser/extensions/platform_app_intent_dispatcher.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/platform_app_browsertest.cc

diff --git a/chrome/browser/extensions/platform_app_browsertest.cc b/chrome/browser/extensions/platform_app_browsertest.cc

index 3aeac39a9f1de56ada32255e07dcb067dd0f81eb..3415e0751383c7e1adad4b862555f97a7d633faa 100644

--- a/chrome/browser/extensions/platform_app_browsertest.cc

+++ b/chrome/browser/extensions/platform_app_browsertest.cc

@@ -196,3 +196,11 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, DisallowStorage) {

IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, MAYBE_WindowsApi) {

ASSERT_TRUE(RunPlatformAppTest("platform_apps/windows_api")) << message_;

}

+IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, DocumentEditor) {

James Hawkins 2012/03/26 19:55:57 nit: Document what the test is testing.

benwells 2012/03/27 04:24:12 Done.

+ CommandLine* command_line = CommandLine::ForCurrentProcess();

+ FilePath test_doc(test_data_dir_.AppendASCII(

+ "platform_apps/document_editor/test.txt"));

+ command_line->AppendArgPath(test_doc);

+ ASSERT_TRUE(RunPlatformAppTest("platform_apps/document_editor")) << message_;

« no previous file with comments | « no previous file | chrome/browser/extensions/platform_app_intent_dispatcher.h » ('j') | chrome/browser/extensions/platform_app_intent_dispatcher.h » ('J')