Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 9844024: Set maxHeight of all overlay pages at startup and on resize (Closed)

Created:
8 years, 9 months ago by Tyler Breisacher (Chromium)
Modified:
8 years, 9 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Set maxHeight of all overlay pages at startup and on resize BUG=119406 TEST=visual NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129437

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M chrome/browser/resources/shared/js/cr/ui/overlay.js View 1 chunk +14 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Tyler Breisacher (Chromium)
Cleaner approach, as discussed yesterday.
8 years, 9 months ago (2012-03-28 16:51:37 UTC) #1
James Hawkins
lgtm
8 years, 9 months ago (2012-03-28 17:46:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbreisacher@chromium.org/9844024/1
8 years, 9 months ago (2012-03-28 17:47:22 UTC) #3
commit-bot: I haz the power
8 years, 9 months ago (2012-03-28 17:47:33 UTC) #4
Change committed as 129437

Powered by Google App Engine
This is Rietveld 408576698