Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9844017: Fixes android.fiy bot base_unittests. (Closed)

Created:
8 years, 9 months ago by bulach
Modified:
8 years, 9 months ago
Reviewers:
Peter Beverloo, Satish
CC:
chromium-reviews, Yaron
Visibility:
Public.

Description

Fixes android.fiy bot base_unittests. Following: http://codereview.chromium.org/9860035 we need to push an extra data file. BUG= TEST=JSONReaderTest.ReadFromFile Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129419

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/android/single_test_runner.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bulach
8 years, 9 months ago (2012-03-28 12:37:33 UTC) #1
Peter Beverloo
LGTM. Asking Satish to RS.
8 years, 9 months ago (2012-03-28 12:53:24 UTC) #2
Satish
lgtm
8 years, 9 months ago (2012-03-28 12:55:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/9844017/1
8 years, 9 months ago (2012-03-28 12:56:47 UTC) #4
bulach
8 years, 9 months ago (2012-03-28 15:29:27 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-28 15:59:31 UTC) #6 
Change committed as 129419

Powered by Google App Engine
This is Rietveld 408576698