Fix wallpaper change to a random one when user first click "set wallpaper".

chrome/browser/chromeos/login/user_manager_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/user_manager_impl.h"
 
 #include <vector>
 
 #include "ash/shell.h"
 #include "ash/desktop_background/desktop_background_controller.h"
@@ skipping 889 matching lines @@
                           base::Bind(&UserManagerImpl::CheckOwnership,
                                      base::Unretained(this)));
 }
 
 void UserManagerImpl::SetInitialUserImage(const std::string& username) {
   // Choose a random default image.
   int image_id = base::RandInt(0, kDefaultImagesCount - 1);
   SaveUserDefaultImageIndex(username, image_id);
 }
 
-int UserManagerImpl::GetUserWallpaper(const std::string& username) {
+int UserManagerImpl::GetUserWallpaperIndex() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
+  // If at login screen or logged in as a guest/incognito user, then use the
+  // randomly generated wallpaper.
+  if (IsLoggedInAsGuest() || !IsUserLoggedIn())

[Nikita (slow), 2012/03/25 21:24:08]

+ IsCurrentUserEphemeral()

In fact you should remove IsLoggedInAsGuest() and add only

if (IsCurrentUserEphemeral() || !IsUserLoggedIn())

IsCurrentUserEphemeral will be true for Demo/Guest/normal users when Ephemeral
policy is enabled / stub user.

Obviously this will block testing change of wallpaper on desktop (where stub
user is normally used) but that should be fixed separately.

+    return ash::GetGuestWallpaperIndex();
+
+  const chromeos::User& user = GetLoggedInUser();
+  std::string username = user.email();
+  DCHECK(!username.empty());
+
   PrefService* local_state = g_browser_process->local_state();
   const DictionaryValue* user_wallpapers =
       local_state->GetDictionary(UserManager::kUserWallpapers);
   int index = ash::GetDefaultWallpaperIndex();
-  user_wallpapers->GetIntegerWithoutPathExpansion(username,
-                                                  &index);
+  if (!user_wallpapers->GetIntegerWithoutPathExpansion(username, &index))
+    SaveUserWallpaperIndex(index);
+
+  DCHECK(index >=0 && index < ash::GetWallpaperCount());
   return index;
 }
 
-void UserManagerImpl::SaveWallpaperDefaultIndex(const std::string& username,
-                                                int wallpaper_index) {
+void UserManagerImpl::SaveUserWallpaperIndex(int wallpaper_index) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+  // If at login screen or logged in as a guest/incognito user, then return.
+  // Guest/incognito user can not change wallpaper according to chromium-os
+  // issue 26900.
+  if (IsLoggedInAsGuest() || !IsUserLoggedIn())

[Nikita (slow), 2012/03/25 21:24:08]

Change IsLoggedInAsGuest() to IsCurrentUserEphemeral() so that ephemeral and
demo users are handled too.

If ephemeral user policy is enabed - no changes should be made to LocalState as
user home will be removed on sign out. All changes should reside in memory.
Demo user / guest user is a variant of ephemeral users.

+    return;
+
+  const chromeos::User& user = GetLoggedInUser();
+  std::string username = user.email();
+  DCHECK(!username.empty());
 
   PrefService* local_state = g_browser_process->local_state();
   DictionaryPrefUpdate wallpapers_update(local_state,
                                          UserManager::kUserWallpapers);
   wallpapers_update->SetWithoutPathExpansion(username,
       new base::FundamentalValue(wallpaper_index));
-  ash::Shell::GetInstance()->desktop_background_controller()->
-      OnDesktopBackgroundChanged();
 }
 
 void UserManagerImpl::SetUserImage(const std::string& username,
                                    int image_index,
                                    const SkBitmap& image) {
   User* user = const_cast<User*>(FindUser(username));
   // User may have been removed by now.
   if (user) {
     // For existing users, a valid image index should have been set upon loading
     // them from Local State.
@@ skipping 275 matching lines @@
     BrowserThread::PostTask(
         BrowserThread::FILE,
         FROM_HERE,
         base::Bind(&UserManagerImpl::DeleteUserImage,
                    base::Unretained(this),
                    image_path));
   }
 }
 
 }  // namespace chromeos