Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 9839073: Added the command line flag that enables CSS Shaders: "--enable-css-custom-filter". (Closed)

Created:
8 years, 9 months ago by achicu
Modified:
8 years, 8 months ago
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Added the command line flag that enables CSS Shaders: "--enable-css-shaders". BUG=119861 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129598

Patch Set 1 #

Patch Set 2 : Patch V2 #

Patch Set 3 : Rebased and changed to "--enable-css-shaders" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M AUTHORS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M content/common/view_messages.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/glue/webpreferences.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webpreferences.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 25 (0 generated)
greggman
it looks ok to me but you'll need approval from people charge of the various ...
8 years, 9 months ago (2012-03-24 04:55:35 UTC) #1
darin (slow to review)
LGTM
8 years, 9 months ago (2012-03-24 06:24:48 UTC) #2
darin (slow to review)
On 2012/03/24 06:24:48, darin wrote: > LGTM I think you can just TBR the other ...
8 years, 9 months ago (2012-03-24 06:25:18 UTC) #3
Jói
LGTM for content/public.
8 years, 9 months ago (2012-03-26 12:20:54 UTC) #4
Jói
> I think you can just TBR the other reviews. This is a very straightforward ...
8 years, 9 months ago (2012-03-26 12:22:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achicu@adobe.com/9839073/1008
8 years, 9 months ago (2012-03-26 16:07:18 UTC) #6
commit-bot: I haz the power
Try job failure for 9839073-1008 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-26 18:45:27 UTC) #7
achicu
On 2012/03/26 18:45:27, I haz the power (commit-bot) wrote: > Try job failure for 9839073-1008 ...
8 years, 9 months ago (2012-03-26 18:52:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achicu@adobe.com/9839073/1008
8 years, 9 months ago (2012-03-26 19:02:03 UTC) #9
commit-bot: I haz the power
Try job failure for 9839073-1008 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-26 21:01:04 UTC) #10
achicu
The build didn't fail because of my change. What can I do to have this ...
8 years, 9 months ago (2012-03-26 21:22:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achicu@adobe.com/9839073/1008
8 years, 9 months ago (2012-03-26 21:25:26 UTC) #12
commit-bot: I haz the power
Try job failure for 9839073-1008 (retry) on win_rel for step "unit_tests" (clobber build). It's a ...
8 years, 9 months ago (2012-03-26 23:36:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achicu@adobe.com/9839073/1008
8 years, 9 months ago (2012-03-28 18:48:21 UTC) #14
commit-bot: I haz the power
Try job failure for 9839073-1008 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-28 21:31:10 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achicu@adobe.com/9839073/1008
8 years, 9 months ago (2012-03-28 21:49:59 UTC) #16
commit-bot: I haz the power
Can't apply patch for file AUTHORS. While running patch -p1 --forward --force; patching file AUTHORS ...
8 years, 9 months ago (2012-03-28 21:50:02 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achicu@adobe.com/9839073/1008
8 years, 9 months ago (2012-03-28 21:51:55 UTC) #18
commit-bot: I haz the power
Can't apply patch for file AUTHORS. While running patch -p1 --forward --force; patching file AUTHORS ...
8 years, 9 months ago (2012-03-28 21:51:58 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achicu@adobe.com/9839073/25001
8 years, 9 months ago (2012-03-28 22:59:22 UTC) #20
commit-bot: I haz the power
Try job failure for 9839073-25001 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-29 02:24:06 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achicu@adobe.com/9839073/25001
8 years, 9 months ago (2012-03-29 04:20:54 UTC) #22
commit-bot: I haz the power
Try job failure for 9839073-25001 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-29 07:07:22 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achicu@adobe.com/9839073/25001
8 years, 9 months ago (2012-03-29 07:08:46 UTC) #24
commit-bot: I haz the power
8 years, 8 months ago (2012-03-29 09:02:31 UTC) #25
Change committed as 129598

Powered by Google App Engine
This is Rietveld 408576698