chromeos: Separate XML parsing code from IntrospectableClient

chromeos: Separate XML parsing code from IntrospectableClient

BUG=119583
TEST=unit_tests --gtest_filter=IntrospectUtilTest.GetInterfacesFromIntrospectResult


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128805

[hashimoto, 2012-03-23 18:48:30]

This change is to move IntrospectableClient to src/chromeos/dbus first

[satorux1, 2012-03-23 18:49:52]

LGTM

[hashimoto, 2012-03-23 18:52:45]

Add missing files, sorry!

[satorux1, 2012-03-23 18:56:19]

LGTM

[keybuk, 2012-03-23 19:47:04]

lgtm, with nits from my own code!! :)

[keybuk, 2012-03-23 19:47:11]

http://codereview.chromium.org/9839064/diff/4001/chrome/browser/chromeos/dbus...
File chrome/browser/chromeos/dbus/introspect_util.cc (right):

http://codereview.chromium.org/9839064/diff/4001/chrome/browser/chromeos/dbus...
chrome/browser/chromeos/dbus/introspect_util.cc:20: const std::string&xml_data)
{
nit: space after &

http://codereview.chromium.org/9839064/diff/4001/chrome/browser/chromeos/dbus...
File chrome/browser/chromeos/dbus/introspect_util.h (right):

http://codereview.chromium.org/9839064/diff/4001/chrome/browser/chromeos/dbus...
chrome/browser/chromeos/dbus/introspect_util.h:18: const std::string&xml_data);
nit: should be a space here after '&' ?

[hashimoto, 2012-03-23 20:18:25]

http://codereview.chromium.org/9839064/diff/4001/chrome/browser/chromeos/dbus...
File chrome/browser/chromeos/dbus/introspect_util.cc (right):

http://codereview.chromium.org/9839064/diff/4001/chrome/browser/chromeos/dbus...
chrome/browser/chromeos/dbus/introspect_util.cc:20: const std::string&xml_data)
{
On 2012/03/23 19:47:11, keybuk wrote:
> nit: space after &

Done.

http://codereview.chromium.org/9839064/diff/4001/chrome/browser/chromeos/dbus...
File chrome/browser/chromeos/dbus/introspect_util.h (right):

http://codereview.chromium.org/9839064/diff/4001/chrome/browser/chromeos/dbus...
chrome/browser/chromeos/dbus/introspect_util.h:18: const std::string&xml_data);
On 2012/03/23 19:47:11, keybuk wrote:
> nit: should be a space here after '&' ?

Done.

[commit-bot: I haz the power, 2012-03-23 20:20:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hashimoto@chromium.org/9839064/4003

[commit-bot: I haz the power, 2012-03-24 02:16:13]

Try job failure for 9839064-4003 (previous was lost) (retry) on win_rel for step
"browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-03-24 02:33:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hashimoto@chromium.org/9839064/4003

[commit-bot: I haz the power, 2012-03-24 05:58:47]

Try job failure for 9839064-4003 (retry) on win_rel for step "browser_tests".
It's a second try, previously, steps "browser_tests, installer_util_unittests"
failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-03-24 17:17:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hashimoto@chromium.org/9839064/5012

[commit-bot: I haz the power, 2012-03-24 19:49:51]

Try job failure for 9839064-5012 (retry) on win_rel for steps "browser_tests,
unit_tests".
It's a second try, previously, steps "browser_tests, unit_tests,
installer_util_unittests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-03-25 03:31:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hashimoto@chromium.org/9839064/5012

[commit-bot: I haz the power, 2012-03-25 04:58:37]

Change committed as 128805