runtime/bin/file_linux.cc - Issue 9839053: Add error handling to random access file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/file_linux.cc

Issue 9839053: Add error handling to random access file (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/file_linux.cc

diff --git a/runtime/bin/file_linux.cc b/runtime/bin/file_linux.cc

index 05ac74dc0a903b11646cd19555df298fc24ffbc7..f04234fbea7a6ef9e3743ebf2324052456605c62 100644

--- a/runtime/bin/file_linux.cc

+++ b/runtime/bin/file_linux.cc

@@ -85,9 +85,9 @@ bool File::Truncate(int64_t length) {

}

-void File::Flush() {

+bool File::Flush() {

ASSERT(handle_->fd() >= 0);

- TEMP_FAILURE_RETRY(fsync(handle_->fd()));

+ return TEMP_FAILURE_RETRY(fsync(handle_->fd()) != -1);

}