Make chrome/browser/chrome_browser_main_linux.* Linux-only.

Make chrome/browser/chrome_browser_main_linux.* Linux-only.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128650

[Lei Zhang, 2012-03-22 23:02:20]

vtl: main reviewer.
stevenjb, robert.nagy: See comments with your names on it.

https://chromiumcodereview.appspot.com/9839028/diff/8001/chrome/browser/chrom...
File chrome/browser/chrome_browser_main_linux.h (left):

https://chromiumcodereview.appspot.com/9839028/diff/8001/chrome/browser/chrom...
chrome/browser/chrome_browser_main_linux.h:20: virtual void
ShowMissingLocaleMessageBox() OVERRIDE;
Yes, I realize this leaves ChromeBrowserMainPartsLinux in an useless state. Rest
assured I intend to add more stuff to this class in the near future.

https://chromiumcodereview.appspot.com/9839028/diff/8001/chrome/browser/chrom...
File chrome/browser/chrome_browser_main_posix.cc (left):

https://chromiumcodereview.appspot.com/9839028/diff/8001/chrome/browser/chrom...
chrome/browser/chrome_browser_main_posix.cc:29: #if defined(TOOLKIT_USES_GTK) &&
!defined(OS_CHROMEOS)
These are mutually exclusive.

https://chromiumcodereview.appspot.com/9839028/diff/8001/chrome/browser/chrom...
File chrome/browser/chrome_browser_main_posix.cc (right):

https://chromiumcodereview.appspot.com/9839028/diff/8001/chrome/browser/chrom...
chrome/browser/chrome_browser_main_posix.cc:279: NOTREACHED();  // Should not
ever happen on ChromeOS.
stevenjb: in r109069, you put USE_AURA here, but I'm guessing you really meant
OS_CHROMEOS, since if we have Linux+Aura, this can happen.

https://chromiumcodereview.appspot.com/9839028/diff/8001/chrome/browser/chrom...
File chrome/browser/chrome_content_browser_client.cc (left):

https://chromiumcodereview.appspot.com/9839028/diff/8001/chrome/browser/chrom...
chrome/browser/chrome_content_browser_client.cc:105: #elif defined(OS_LINUX) ||
defined(OS_OPENBSD)
Robert Nagt: I'm going to "do the right thing" and move this into the POSIX
implementation. I hope you are making progress in not include _linux files in
the OpenBSD build.

[Lei Zhang, 2012-03-22 23:03:37]

https://chromiumcodereview.appspot.com/9839028/diff/8001/chrome/browser/chrom...
File chrome/browser/chrome_content_browser_client.cc (left):

https://chromiumcodereview.appspot.com/9839028/diff/8001/chrome/browser/chrom...
chrome/browser/chrome_content_browser_client.cc:105: #elif defined(OS_LINUX) ||
defined(OS_OPENBSD)
On 2012/03/22 23:02:20, Lei Zhang wrote:
> Robert Nagt: I'm going to "do the right thing" and move this into the POSIX
> implementation. I hope you are making progress in not include _linux files in
> the OpenBSD build.

s/Nagt/Nagy/.

[stevenjb, 2012-03-22 23:31:04]

Thanks for doing this!

http://codereview.chromium.org/9839028/diff/8001/chrome/browser/chrome_browse...
File chrome/browser/chrome_browser_main_posix.cc (right):

http://codereview.chromium.org/9839028/diff/8001/chrome/browser/chrome_browse...
chrome/browser/chrome_browser_main_posix.cc:279: NOTREACHED();  // Should not
ever happen on ChromeOS.
On 2012/03/22 23:02:20, Lei Zhang wrote:
> stevenjb: in r109069, you put USE_AURA here, but I'm guessing you really meant
> OS_CHROMEOS, since if we have Linux+Aura, this can happen.

Aura should never call ShowMissingLocaleMessageBox. There is no AURA + GTK, so
if you make this #if CHROMEOS, this would #error on Linux + Aura (not chromeos),
right?

[Lei Zhang, 2012-03-22 23:37:10]

http://codereview.chromium.org/9839028/diff/8001/chrome/browser/chrome_browse...
File chrome/browser/chrome_browser_main_posix.cc (right):

http://codereview.chromium.org/9839028/diff/8001/chrome/browser/chrome_browse...
chrome/browser/chrome_browser_main_posix.cc:279: NOTREACHED();  // Should not
ever happen on ChromeOS.
On 2012/03/22 23:31:07, stevenjb (chromium) wrote:
> On 2012/03/22 23:02:20, Lei Zhang wrote:
> > stevenjb: in r109069, you put USE_AURA here, but I'm guessing you really
meant
> > OS_CHROMEOS, since if we have Linux+Aura, this can happen.
> 
> Aura should never call ShowMissingLocaleMessageBox. There is no AURA + GTK, so
> if you make this #if CHROMEOS, this would #error on Linux + Aura (not
chromeos),
> right?
> 

Yes, this would be #error on Linux + Aura, which does not exist yet. When/if it
does, the devs will see the #error and deal with it accordingly.

[Robert Nagy, 2012-03-23 08:13:05]

> defined(OS_OPENBSD)
> Robert Nagt: I'm going to "do the right thing" and move this into the POSIX
> implementation. I hope you are making progress in not include _linux files in
> the OpenBSD build.

This patchset works fine for me. Yes I am working on it as time allows.
Thanks

[stevenjb, 2012-03-23 17:03:40]

+erg@ who I believe is working on Linux + Aura

[Elliot Glaysher, 2012-03-23 17:19:09]

lgtm

[stevenjb, 2012-03-23 17:20:09]

Then lgtm also :)

[viettrungluu, 2012-03-23 19:14:43]

lgtm

[commit-bot: I haz the power, 2012-03-23 19:32:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/9839028/13001

[commit-bot: I haz the power, 2012-03-24 01:43:29]

Change committed as 128650