Add a sign-in promo message to the Other Devices menu.

chrome/browser/resources/ntp4/new_tab.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview New tab page
  * This is the main code for the new tab page used by touch-enabled Chrome
  * browsers.  For now this is still a prototype.
  */
 
@@ skipping 79 matching lines @@
 
       if (infoBubble)
         window.setTimeout(infoBubble.reposition.bind(infoBubble), 0);
     }
   };
 
   /**
    * Invoked at startup once the DOM is available to initialize the app.
    */
   function onLoad() {
+    var isUserSignedIn = Boolean(
+        localStrings.getString('login_status_message'));

[Dan Beam, 2012/03/23 21:12:47]

Casting to Boolean() is a little different than just saying

  if (localString.getString('login_status_message'))

as well as this just shows a message, which could be present whether logged in
or not...  you should check if their GAIA users name is empty or get this
information from the sync service.

[Patrick Dubroy, 2012/03/26 15:16:46]

What's the difference? According to the spec it should be the same.
 
Ok, good point. Done.

[Dan Beam, 2012/03/26 17:08:33]

tl;dr casting or comparing to different types in JS causes some unexpected
results:

  if ([]) alert('yep');
  if ([] == true) alert('nope');

     cr.enablePlatformSpecificCSSRules();
 
     sectionsToWaitFor = templateData.showApps ? 2 : 1;
     measureNavDots();
 
     // Load the current theme colors.
     themeChanged();
 
     newTabView = new NewTabView();
 
     notificationContainer = getRequiredElement('notification-container');
     notificationContainer.addEventListener(
         'webkitTransitionEnd', onNotificationTransitionEnd);
 
     cr.ui.decorate($('recently-closed-menu-button'), ntp.RecentMenuButton);
     chrome.send('getRecentlyClosedTabs');
 
     if (templateData.showOtherSessionsMenu) {
       cr.ui.decorate($('other-sessions-menu-button'),
                      ntp.OtherSessionsMenuButton);
+      $('other-sessions-menu-button').initialize(
+          isUserSignedIn, showSyncLoginUI);
     }
 
     var mostVisited = new ntp.MostVisitedPage();
     // Move the footer into the most visited page if we are in "bare minimum"
     // mode.
     if (document.body.classList.contains('bare-minimum'))
       mostVisited.appendFooter(getRequiredElement('footer'));
     newTabView.appendTilePage(mostVisited,
                               localStrings.getString('mostvisited'),
                               false);
@@ skipping 20 matching lines @@
       $('chrome-web-store-href').addEventListener('click',
           onChromeWebStoreButtonClick);
 
       $('footer-content').classList.add('enable-cws-experiment');
     }
 
     if (templateData.appInstallHintEnabled) {
       var url = appendParam(webstoreLink, 'utm_source', 'chrome-ntp-plus-icon');
       $('app-install-hint-template').href = url;
     }
-
-    if (localStrings.getString('login_status_message')) {
+    if (isUserSignedIn) {

[Dan Beam, 2012/03/23 21:12:47]

I'd undo this.

[Patrick Dubroy, 2012/03/26 15:16:46]

Done.

       loginBubble = new cr.ui.Bubble;
       loginBubble.anchorNode = $('login-container');
       loginBubble.setArrowLocation(cr.ui.ArrowLocation.TOP_END);
       loginBubble.bubbleAlignment =
           cr.ui.BubbleAlignment.BUBBLE_EDGE_TO_ANCHOR_EDGE;
       loginBubble.deactivateToDismissDelay = 2000;
       loginBubble.setCloseButtonVisible(false);
 
       $('login-status-learn-more').href =
           localStrings.getString('login_status_url');
@@ skipping 37 matching lines @@
                  /^data\:image\/(?:png|gif|jpe?g)/.test(value);
         },
       };
       showNotification(parseHtmlSubset(promo, tags, attrs), [], function() {
         chrome.send('closeNotificationPromo');
       }, 60000);
       chrome.send('notificationPromoViewed');
     }
 
     var loginContainer = getRequiredElement('login-container');
-    loginContainer.addEventListener('click', function() {
-      var rect = loginContainer.getBoundingClientRect();
-      chrome.send('showSyncLoginUI',
-                  [rect.left, rect.top, rect.width, rect.height]);
+    loginContainer.addEventListener('click', function(e) {
+      showSyncLoginUI(this);

[Dan Beam, 2012/03/23 21:12:47]

can you change this to

  loginContainer.addEventListener('click', showSyncLoginUI);

[Patrick Dubroy, 2012/03/26 19:36:46]

Done.

     });
     chrome.send('initializeSyncLogin');
 
     doWhenAllSectionsReady(function() {
       // Tell the slider about the pages.
       newTabView.updateSliderCards();
       // Mark the current page.
       newTabView.cardSlider.currentCardValue.navigationDot.classList.add(
           'selected');
 
@@ skipping 253 matching lines @@
    */
   function setStripeColor(id, color) {
     var node = $(id);
     if (node)
       node.stripeColor = color;
   }
 
   /**
    * Updates the text displayed in the login container. If there is no text then
    * the login container is hidden.
+   * @param {Boolean} isUserSignedIn Indicates if the user is signed in or not.
    * @param {string} loginHeader The first line of text.
    * @param {string} loginSubHeader The second line of text.
    * @param {string} iconURL The url for the login status icon. If this is null
         then the login status icon is hidden.
    */
-  function updateLogin(loginHeader, loginSubHeader, iconURL) {
+  function updateLogin(isUserSignedIn, loginHeader, loginSubHeader, iconURL) {
     if (loginHeader || loginSubHeader) {
       $('login-container').hidden = false;
       $('login-status-header').innerHTML = loginHeader;
       $('login-status-sub-header').innerHTML = loginSubHeader;
       $('card-slider-frame').classList.add('showing-login-area');
 
       if (iconURL) {
         $('login-status-header-container').style.backgroundImage = url(iconURL);
         $('login-status-header-container').classList.add('login-status-icon');
       } else {
         $('login-status-header-container').style.backgroundImage = 'none';
         $('login-status-header-container').classList.remove(
             'login-status-icon');
       }
     } else {
       $('login-container').hidden = true;
       $('card-slider-frame').classList.remove('showing-login-area');
     }
     if (shouldShowLoginBubble) {
       window.setTimeout(loginBubble.show.bind(loginBubble), 0);
       chrome.send('loginMessageSeen');
       shouldShowLoginBubble = false;
     } else if (loginBubble) {
       loginBubble.reposition();
     }
+    $('other-sessions-menu-button').updateSignInState(isUserSignedIn);
   }
 
   /**
+   * Show the sync login UI. |element| is the element that triggered the login.

[Dan Beam, 2012/03/23 21:12:47]

doc param

[Patrick Dubroy, 2012/03/26 15:16:46]

Done.

+   */
+  function showSyncLoginUI(element) {

[Dan Beam, 2012/03/23 21:12:47]

s/element/e/

var element = e.currentTarget;

[Patrick Dubroy, 2012/03/26 15:16:46]

Done.

+    var rect = element.getBoundingClientRect();
+    chrome.send('showSyncLoginUI',
+                [rect.left, rect.top, rect.width, rect.height]);
+  }
+
+  /**
    * Wrappers to forward the callback to corresponding PageListView member.
    */
   function appAdded() {
     return newTabView.appAdded.apply(newTabView, arguments);
   }
 
   function appMoved() {
     return newTabView.appMoved.apply(newTabView, arguments);
   }
 
@@ skipping 61 matching lines @@
     setSuggestionsPages: setSuggestionsPages,
     setRecentlyClosedTabs: setRecentlyClosedTabs,
     setStripeColor: setStripeColor,
     showNotification: showNotification,
     themeChanged: themeChanged,
     updateLogin: updateLogin
   };
 });
 
 document.addEventListener('DOMContentLoaded', ntp.onLoad);