Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2149)

Unified Diff: chrome/browser/resources/options2/font_settings.js

Issue 9838055: Fixed bidi RTL check failures on font settings page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sets the directionality from the contents of the font strings. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/bidi_checker_web_ui_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options2/font_settings.js
diff --git a/chrome/browser/resources/options2/font_settings.js b/chrome/browser/resources/options2/font_settings.js
index 19d4cf658237e368555867e47a0ba583b64031a6..27570e1d2634a4a773a305acecd50b1ff5fed7be 100644
--- a/chrome/browser/resources/options2/font_settings.js
+++ b/chrome/browser/resources/options2/font_settings.js
@@ -170,9 +170,12 @@ cr.define('options', function() {
for (var i = 0; i < items.length; i++) {
value = items[i][0];
text = items[i][1];
+ dir = items[i][2];
if (text) {
selected = value == selectedValue;
- element.appendChild(new Option(text, value, false, selected));
+ var option = new Option(text, value, false, selected);
+ option.dir = dir;
+ element.appendChild(option);
} else {
element.appendChild(document.createElement('hr'));
}
« no previous file with comments | « no previous file | chrome/browser/ui/webui/bidi_checker_web_ui_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698