Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: chrome/browser/ui/webui/bidi_checker_web_ui_test.cc

Issue 9838055: Fixed bidi RTL check failures on font settings page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sets the directionality from the contents of the font strings. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/bidi_checker_web_ui_test.h" 5 #include "chrome/browser/ui/webui/bidi_checker_web_ui_test.h"
6 6
7 #include "base/base_paths.h" 7 #include "base/base_paths.h"
8 #include "base/i18n/rtl.h" 8 #include "base/i18n/rtl.h"
9 #include "base/path_service.h" 9 #include "base/path_service.h"
10 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
(...skipping 655 matching lines...) Expand 10 before | Expand all | Expand 10 after
666 // chrome://settings-frame/fonts 666 // chrome://settings-frame/fonts
667 //======================================== 667 //========================================
668 668
669 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR, 669 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR,
670 TestSettingsFrameFonts) { 670 TestSettingsFrameFonts) {
671 std::string url(chrome::kChromeUISettingsFrameURL); 671 std::string url(chrome::kChromeUISettingsFrameURL);
672 url += "fonts"; 672 url += "fonts";
673 RunBidiCheckerOnPage(url); 673 RunBidiCheckerOnPage(url);
674 } 674 }
675 675
676 // http://crbug.com/118420
677 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL, 676 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL,
678 DISABLED_TestSettingsFrameFonts) { 677 TestSettingsFrameFonts) {
679 std::string url(chrome::kChromeUISettingsFrameURL); 678 std::string url(chrome::kChromeUISettingsFrameURL);
680 url += "fonts"; 679 url += "fonts";
681 RunBidiCheckerOnPage(url); 680 RunBidiCheckerOnPage(url);
682 } 681 }
683 682
684 // Test other uber iframes. 683 // Test other uber iframes.
685 684
686 //============================== 685 //==============================
687 // chrome://extensions-frame 686 // chrome://extensions-frame
688 //============================== 687 //==============================
(...skipping 23 matching lines...) Expand all
712 // chrome://history-frame 711 // chrome://history-frame
713 //============================== 712 //==============================
714 713
715 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR, TestHistoryFrame) { 714 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR, TestHistoryFrame) {
716 RunBidiCheckerOnPage(chrome::kChromeUIHistoryFrameURL); 715 RunBidiCheckerOnPage(chrome::kChromeUIHistoryFrameURL);
717 } 716 }
718 717
719 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL, TestHistoryFrame) { 718 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL, TestHistoryFrame) {
720 RunBidiCheckerOnPage(chrome::kChromeUIHistoryFrameURL); 719 RunBidiCheckerOnPage(chrome::kChromeUIHistoryFrameURL);
721 } 720 }
OLDNEW
« no previous file with comments | « chrome/browser/resources/options2/font_settings.js ('k') | chrome/browser/ui/webui/options2/font_settings_handler2.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698