Automatically remap Command key on an Apple keyboard to Control [part 1 of 2 - Ash part]

ash/key_rewriter_delegate.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ASH_KEY_REWRITER_DELEGATE_H_
+#define ASH_KEY_REWRITER_DELEGATE_H_
+#pragma once
+
+namespace aura {
+class KeyEvent;
+}  // namespace aura
+
+namespace ash {
+
+// Delegate for rewriting or filtering a key event.
+class KeyRewriterDelegate {
+ public:
+  virtual ~KeyRewriterDelegate() {}
+
+  // A derived class should do either of the following:
+  // 1) Just return true to filter out the |event|.
+  // 2) Rewrite the |event| and return false.
+  virtual bool RewriteOrFilterKeyEvent(aura::KeyEvent* event) = 0;

[Daniel Erat, 2012/03/26 15:40:30]

i never know what true and false mean in the return values from filtering
methods.  please add an enum to this class instead, like:

  enum Action {
    ACTION_REWRITE_EVENT,
    ACTION_DROP_EVENT,
  };

  virtual Action RewriteKeyEvent(aura::KeyEvent* event) = 0;

it might be better to avoid the word "filter" here to avoid confusion with
EventFilter.

[Yusuke Sato, 2012/03/26 16:06:28]

Done.

+};
+
+}  // namespace ash
+
+#endif  // ASH_KEY_REWRITER_DELEGATE_H_