Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 9837124: Add ShareGroup to GLES2Implemenation (Closed)

Created:
8 years, 9 months ago by greggman
Modified:
8 years, 9 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Add ShareGroup to GLES2Implemenation The idea is if you don't pass a ShareGroup it will make one. Otherwise you can do new_gles2_impl = new GLES2Implemetation( ..., some_other_gles2_impl_in_same_process->share_group(), ...); TEST=unit test BUG=120297 TBR=nfullgar@google.com,brettw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129555

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M content/common/gpu/client/content_gl_context.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 5 chunks +9 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M gpu/demos/framework/window.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/gles2_conform_support/egl/display.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_graphics_3d.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/shared_impl/ppb_graphics_3d_shared.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
greggman
Hey Al, more PREP, PTAL should I just TBR everyone else?
8 years, 9 months ago (2012-03-28 21:17:10 UTC) #1
apatrick_chromium
LGTM. Though the try bots don't seem to have synced to a revision with client/ref_counted.
8 years, 9 months ago (2012-03-28 21:50:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/9837124/1
8 years, 9 months ago (2012-03-28 23:26:34 UTC) #3
commit-bot: I haz the power
8 years, 9 months ago (2012-03-29 01:51:43 UTC) #4
Change committed as 129555

Powered by Google App Engine
This is Rietveld 408576698