Issue 9837082: Do not try to get a display name from an input method ID which starts with "_ext_ime".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9837082: Do not try to get a display name from an input method ID which starts with "_ext_ime". (Closed)

Created:
8 years, 9 months ago by Yusuke Sato

Modified:
8 years, 9 months ago

Reviewers:
Zachary Kuznia

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Do not try to get a display name from an input method ID which starts with "_ext_ime". BUG=None TEST=Load an extension IME, check ui.LATEST log, confirm LOG(ERROR)s are not written. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128892

Patch Set 1 #

Patch Set 2 : review #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -1 line)			Patch
M	chrome/browser/chromeos/input_method/input_method_util.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util.cc	View		3 chunks	+14 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util_unittest.cc	View	1	2 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yusuke Sato

Related to your CL at http://codereview.chromium.org/9856011/

8 years, 9 months ago (2012-03-26 06:55:58 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/9837082/2001

8 years, 9 months ago (2012-03-26 10:09:52 UTC) #3

Change committed as 128892

Expand Messages | Collapse Messages