Move power_supply_status.* from src/ash to src/chromeos

Copy ash/system/power/power_supply_status.* to src/chromeos

Copy power_supply_status.*
Move #ifdef trick from power_manager_client.h to power_supply_status.h
Add chromeos.gyp
Add dependency from ash to chromeos when chromeos==1

BUG=119583
TEST=build success, checkdeps success

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=130796

[hashimoto, 2012-03-24 01:25:27]

oshima: Please review src/chromeos changes
satorux: Please review browser/chromeos/dbus changes
sadrul: Please review ash/system/power changes

This patch will be followed by http://codereview.chromium.org/9838085/

[sadrul, 2012-03-24 01:38:32]

ash/system changes LGTM

[Being able to use some chromeos:: in ash/ and some not is going to be rather
confusing, I think. But that's a separate issue.]

[oshima, 2012-03-24 06:46:04]

http://codereview.chromium.org/9837075/diff/3014/ash/system/power/power_statu...
File ash/system/power/power_status_observer.h (right):

http://codereview.chromium.org/9837075/diff/3014/ash/system/power/power_statu...
ash/system/power/power_status_observer.h:8: namespace chromeos {
did you mean to move this to chromeos/dbus?

http://codereview.chromium.org/9837075/diff/3014/chromeos/chromeos.gyp
File chromeos/chromeos.gyp (right):

http://codereview.chromium.org/9837075/diff/3014/chromeos/chromeos.gyp#newcode12
chromeos/chromeos.gyp:12: 'type': 'static_library',
any reason not '<(component)' ?

[oshima, 2012-03-24 06:50:46]

We still want to compile ash on windows, with proper ifdefs. Does this compile
on windows?

http://codereview.chromium.org/9837075/diff/3014/chromeos/chromeos.gyp
File chromeos/chromeos.gyp (right):

http://codereview.chromium.org/9837075/diff/3014/chromeos/chromeos.gyp#newcode11
chromeos/chromeos.gyp:11: 'target_name': 'chromeos_libs',
just 'chromeos'

[satorux1, 2012-03-24 06:53:36]

chrome/browser/chromeos lgtm

[hashimoto, 2012-03-24 07:35:59]

http://codereview.chromium.org/9837075/diff/3014/ash/system/power/power_statu...
File ash/system/power/power_status_observer.h (right):

http://codereview.chromium.org/9837075/diff/3014/ash/system/power/power_statu...
ash/system/power/power_status_observer.h:8: namespace chromeos {
On 2012/03/24 06:46:04, oshima wrote:
> did you mean to move this to chromeos/dbus?

I want to move this to ::chromeos because PowerManagerClient is in ::chromeos
even if its code is in chromeos/dbus

[oshima, 2012-03-24 19:15:30]

http://codereview.chromium.org/9837075/diff/3014/ash/system/power/power_statu...
File ash/system/power/power_status_observer.h (right):

http://codereview.chromium.org/9837075/diff/3014/ash/system/power/power_statu...
ash/system/power/power_status_observer.h:8: namespace chromeos {
On 2012/03/24 07:36:00, hashimoto wrote:
> On 2012/03/24 06:46:04, oshima wrote:
> > did you mean to move this to chromeos/dbus?
> 
> I want to move this to ::chromeos because PowerManagerClient is in ::chromeos
> even if its code is in chromeos/dbus

Not sure if I understand. Can you elaborate?

[hashimoto, 2012-03-25 07:09:31]

http://codereview.chromium.org/9837075/diff/3014/ash/system/power/power_statu...
File ash/system/power/power_status_observer.h (right):

http://codereview.chromium.org/9837075/diff/3014/ash/system/power/power_statu...
ash/system/power/power_status_observer.h:8: namespace chromeos {
On 2012/03/24 19:15:30, oshima wrote:
> On 2012/03/24 07:36:00, hashimoto wrote:
> > On 2012/03/24 06:46:04, oshima wrote:
> > > did you mean to move this to chromeos/dbus?
> > 
> > I want to move this to ::chromeos because PowerManagerClient is in
::chromeos
> > even if its code is in chromeos/dbus
> 
> Not sure if I understand. Can you elaborate?

The reason why I place PowerSupplyStatus under namespace chromeos instead of
chromeos::dbus is PowerSupplyStatus is typedef-ed in namespace chromeos in
power_manager_client.h.
(http://codereview.chromium.org/9837075/diff/3014/chrome/browser/chromeos/dbus...)
But, while PowerSupplyStatus is placed in namespace chromeos,
power_supply_status.h should be placed in src/chromeos/dbus instead of
src/chromeos because PowerManagerClient, one of its main users, is going to move
to src/chromeos/dbus.

Does this answer your question correctly?

[hashimoto, 2012-03-26 22:52:13]

New patch set,
Copy power_supply_status.h/cc instead of move for non chromeos aura builds.

http://codereview.chromium.org/9837075/diff/3014/chromeos/chromeos.gyp
File chromeos/chromeos.gyp (right):

http://codereview.chromium.org/9837075/diff/3014/chromeos/chromeos.gyp#newcode11
chromeos/chromeos.gyp:11: 'target_name': 'chromeos_libs',
On 2012/03/24 06:50:46, oshima wrote:
> just 'chromeos'

Done.

http://codereview.chromium.org/9837075/diff/3014/chromeos/chromeos.gyp#newcode12
chromeos/chromeos.gyp:12: 'type': 'static_library',
On 2012/03/24 06:46:04, oshima wrote:
> any reason not '<(component)' ?

Done.

[hashimoto, 2012-04-03 23:29:51]

oshima,

Could you take a look?

[oshima, 2012-04-04 00:04:09]

I think we should remove power status stuff from win/ash build. I'll take that
so this CL is LGTM.

[hashimoto, 2012-04-04 00:08:46]

Ben,

Could you review this change as an owner of ash/ ?

[Ben Goodger (Google), 2012-04-04 16:20:59]

lgtm

[commit-bot: I haz the power, 2012-04-04 17:22:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hashimoto@chromium.org/9837075/14001

[commit-bot: I haz the power, 2012-04-04 18:39:34]

Try job failure for 9837075-14001 (previous was lost) (retry) on win for step
"compile" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-04-04 21:58:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hashimoto@chromium.org/9837075/14001

[commit-bot: I haz the power, 2012-04-04 22:52:38]

Try job failure for 9837075-14001 (retry) on linux_rel for step "gpu_unittests".
It's a second try, previously, step "gpu_unittests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...