Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7651)

Unified Diff: chrome/common/extensions/extension.cc

Issue 9837074: Make it so that allow_js_access: false can be used with background pages created by window.open. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review feedback Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension.cc
diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc
index 4ef186a58bf4c447068aa6f00017e923e2699dd8..f6383c2134a3d1f88ed34f4e13591dcd0d63c902 100644
--- a/chrome/common/extensions/extension.cc
+++ b/chrome/common/extensions/extension.cc
@@ -1834,11 +1834,6 @@ bool Extension::LoadBackgroundAllowJSAccess(
return false;
}
- if (!has_background_page()) {
- *error = ASCIIToUTF16(errors::kInvalidBackgroundAllowJsAccessNoPage);
- return false;
- }
-
return true;
}

Powered by Google App Engine
This is Rietveld 408576698