Make it so that allow_js_access: false can be used with background pages created by window.open.

content/public/browser/web_contents_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_DELEGATE_H_
 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_DELEGATE_H_
 #pragma once
 
 #include <set>
 #include <string>
@@ skipping 255 matching lines @@
   // Returns whether this tab contents should add the specified navigation to
   // history.
   virtual bool ShouldAddNavigationToHistory(
       const history::HistoryAddPageArgs& add_page_args,
       NavigationType navigation_type);
 
   // Returns the native window framing the view containing the tab contents.
   virtual gfx::NativeWindow GetFrameNativeWindow();
 
   // Allows delegate to control whether a WebContents will be created. Returns
   // true to allow the creation. Default is to allow it.

[Charlie Reis, 2012/03/27 23:19:27]

Should we mention that |target_url| isn't normally used, unless the delegate
intercepts the navigation and handles it itself?

[Mihai Parparita -not on Chrome, 2012/03/28 20:29:01]

In theory, a delegate could also make decisions based on the target URL (it just
hasn't needed to so far), but I've added a comment about the URL being used if
the delegate handles creation/navigation.

   virtual bool ShouldCreateWebContents(
       WebContents* web_contents,
       int route_id,
       WindowContainerType window_container_type,
-      const string16& frame_name);
+      const string16& frame_name,
+      const GURL& target_url);
 
   // Notifies the delegate about the creation of a new WebContents. This
   // typically happens when popups are created.
   virtual void WebContentsCreated(WebContents* source_contents,
                                   int64 source_frame_id,
                                   const GURL& target_url,
                                   WebContents* new_contents) {}
 
   // Notifies the delegate that the content restrictions for this tab has
   // changed.
@@ skipping 112 matching lines @@
   // Called when |this| is no longer the WebContentsDelegate for |source|.
   void Detach(WebContents* source);
 
   // The WebContents that this is currently a delegate for.
   std::set<WebContents*> attached_contents_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_DELEGATE_H_