Make it so that allow_js_access: false can be used with background pages created by window.open.

content/public/browser/content_browser_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
 #define CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_
 #pragma once
 
 #include <string>
 #include <utility>
@@ skipping 73 matching lines @@
 // principal implementation. The methods are assumed to be called on the UI
 // thread unless otherwise specified. Use this "escape hatch" sparingly, to
 // avoid the embedder interface ballooning and becoming very specific to Chrome.
 // (Often, the call out to the client can happen in a different part of the code
 // that either already has a hook out to the embedder, or calls out to one of
 // the observer interfaces.)
 class ContentBrowserClient {
  public:
   virtual ~ContentBrowserClient() {}
 
+  enum CanCreateWindowResult {

[jam, 2012/03/28 02:38:26]

nit: see hte other enums in content API to see the convention, i.e. this would
be CAN_CREATE_WINDOW_RESULTS_DISALLOW, ...ALLOW, ...ALLOW_NO_JS_ACCESS.

but can we avoid the enum altogether? because if you add it and are passing it
around in content, by convention to the API this needs to be in a separate file
which seems nice to avoid (we try to keep the files in the public directories to
a minimum). so another boolean out parameter on the function that is
"no_javascript_access" (we also don't abbreviate per the style guide)

[Mihai Parparita -not on Chrome, 2012/03/28 20:29:01]

Went with the boolean out parameter approach.

+    // The given window canot be created.

[Charlie Reis, 2012/03/27 23:19:27]

nit: cannot

[Mihai Parparita -not on Chrome, 2012/03/28 20:29:01]

Obsolete, this enum is gone per John's comments.

+    CANNOT_CREATE_WINDOW,
+    // The given window can be created.
+    CAN_CREATE_WINDOW,
+    // The given window can be created, but it is not allowed to be scriptable,
+    // and should be put in a separate process.
+    CAN_CREATE_WINDOW_NO_JS_ACCESS
+  };
+
   // Allows the embedder to set any number of custom BrowserMainParts
   // implementations for the browser startup code. See comments in
   // browser_main_parts.h.
   virtual BrowserMainParts* CreateBrowserMainParts(
       const content::MainFunctionParams& parameters) = 0;
 
   // Allows an embedder to return their own WebContentsView implementation.
   // Return NULL to let the default one for the platform be created.
   virtual WebContentsView* OverrideCreateWebContentsView(
       WebContents* web_contents) = 0;
@@ skipping 219 matching lines @@
       int render_process_id,
       int render_view_id,
       bool worker) = 0;
 
   // Cancels a displayed desktop notification.
   virtual void CancelDesktopNotification(
       int render_process_id,
       int render_view_id,
       int notification_id) = 0;
 
-  // Returns true if the given page is allowed to open a window of the given
+  // Returns whether the given page is allowed to open a window of the given
   // type.
   // This is called on the IO thread.
-  virtual bool CanCreateWindow(
+  virtual CanCreateWindowResult CanCreateWindow(
       const GURL& opener_url,
       const GURL& source_origin,
       WindowContainerType container_type,
       content::ResourceContext* context,
       int render_process_id) = 0;
 
   // Returns a title string to use in the task manager for a process host with
   // the given URL, or the empty string to fall back to the default logic.
   // This is called on the IO thread.
   virtual std::string GetWorkerProcessTitle(
@@ skipping 71 matching lines @@
   // This is called on a worker thread.
   virtual
       crypto::CryptoModuleBlockingPasswordDelegate* GetCryptoPasswordDelegate(
           const GURL& url) = 0;
 #endif
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_CONTENT_BROWSER_CLIENT_H_