Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 9837045: Expand usage of platform-apps flag and permission features. (Closed)

Created:
8 years, 9 months ago by miket_OOO
Modified:
8 years, 9 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org
Visibility:
Public.

Description

Expand usage of platform-apps flag and permission features. Reapplication of http://codereview.chromium.org/9834022/ with the VerifyPermissions test #ifdefed out for Windows. BUG=119758 TEST=added Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128610

Patch Set 1 #

Total comments: 1

Patch Set 2 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -28 lines) Patch
M chrome/browser/extensions/api/dns/dns_apitest.cc View 4 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/serial/serial_apitest.cc View 1 chunk +5 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/socket/socket_apitest.cc View 3 chunks +6 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_apitest.h View 1 1 chunk +17 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_apitest.cc View 1 2 chunks +60 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_browsertest.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 3 chunks +16 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension.cc View 1 3 chunks +8 lines, -1 line 0 comments Download
M chrome/common/extensions/extension_manifest_constants.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/extension_manifest_constants.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
miket_OOO
http://codereview.chromium.org/9837045/diff/1/chrome/browser/extensions/extension_apitest.cc File chrome/browser/extensions/extension_apitest.cc (right): http://codereview.chromium.org/9837045/diff/1/chrome/browser/extensions/extension_apitest.cc#newcode325 chrome/browser/extensions/extension_apitest.cc:325: #if defined(OS_WIN) This #ifdef is the only change between ...
8 years, 9 months ago (2012-03-23 17:12:03 UTC) #1
asargent_no_longer_on_chrome
LGTM
8 years, 9 months ago (2012-03-23 17:15:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miket@chromium.org/9837045/1
8 years, 9 months ago (2012-03-23 19:09:29 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
8 years, 9 months ago (2012-03-23 22:58:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miket@chromium.org/9837045/1
8 years, 9 months ago (2012-03-23 23:03:05 UTC) #5
commit-bot: I haz the power
Can't apply patch for file chrome/common/extensions/extension_manifest_constants.cc. While running patch -p1 --forward --force; patching file chrome/common/extensions/extension_manifest_constants.cc ...
8 years, 9 months ago (2012-03-23 23:03:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miket@chromium.org/9837045/4002
8 years, 9 months ago (2012-03-23 23:29:06 UTC) #7
commit-bot: I haz the power
8 years, 9 months ago (2012-03-23 23:29:09 UTC) #8
Can't apply patch for file chrome/browser/extensions/api/dns/dns_apitest.cc.
While running patch -p1 --forward --force;
patching file chrome/browser/extensions/api/dns/dns_apitest.cc
Hunk #1 FAILED at 2.
Hunk #2 FAILED at 21.
Hunk #3 FAILED at 30.
Hunk #4 succeeded at 101 with fuzz 2 (offset -4 lines).
3 out of 4 hunks FAILED -- saving rejects to file
chrome/browser/extensions/api/dns/dns_apitest.cc.rej

Powered by Google App Engine
This is Rietveld 408576698