[Web Intents] CWS inline install for GTK

chrome/browser/ui/gtk/web_intent_picker_gtk.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/gtk/web_intent_picker_gtk.h"
 
 #include <algorithm>
 
 #include "base/i18n/rtl.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/favicon/favicon_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/gtk/browser_toolbar_gtk.h"
 #include "chrome/browser/ui/gtk/browser_window_gtk.h"
 #include "chrome/browser/ui/gtk/custom_button.h"
 #include "chrome/browser/ui/gtk/gtk_chrome_link_button.h"
 #include "chrome/browser/ui/gtk/gtk_util.h"
 #include "chrome/browser/ui/gtk/location_bar_view_gtk.h"
 #include "chrome/browser/ui/gtk/tab_contents_container_gtk.h"
 #include "chrome/browser/ui/gtk/theme_service_gtk.h"
+#include "chrome/browser/ui/gtk/throbber_gtk.h"
 #include "chrome/browser/ui/intents/web_intent_picker_controller.h"
 #include "chrome/browser/ui/intents/web_intent_picker_delegate.h"
 #include "chrome/browser/ui/intents/web_intent_picker_model.h"
 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "content/public/browser/notification_source.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/web_contents.h"
@@ skipping 20 matching lines @@
 // The length in pixels of the label at the bottom of the picker. Text longer
 // than this width will wrap.
 const int kWebStoreLabelLength = 400;
 
 // The pixel size of the header label when using a non-native theme.
 const int kHeaderLabelPixelSize = 15;
 
 // The maximum width in pixels of a suggested extension's title link.
 const int kTitleLinkMaxWidth = 130;
 
+// Indices of the extension row widgets.
+enum {
+  kIconIndex,
+  kTitleLinkIndex,
+  kStarsIndex,
+  kInstallButtonIndex,
+};
+
 ThemeServiceGtk *GetThemeService(TabContentsWrapper* wrapper) {
   return ThemeServiceGtk::GetFrom(wrapper->profile());
 }
 
 // Set the image of |button| to |pixbuf|.
 void SetServiceButtonImage(GtkWidget* button, GdkPixbuf* pixbuf) {
   gtk_button_set_image(GTK_BUTTON(button), gtk_image_new_from_pixbuf(pixbuf));
   gtk_button_set_image_position(GTK_BUTTON(button), GTK_POS_LEFT);
 }
 
 // Get the index of the row containing |widget|. Assume the widget is the child
 // of an hbox, which is a child of a vbox. The hbox represents a row, and the
 // vbox the full table.
 size_t GetExtensionWidgetRow(GtkWidget* widget) {
   GtkWidget* hbox = gtk_widget_get_parent(widget);
   DCHECK(hbox);
   GtkWidget* vbox = gtk_widget_get_parent(hbox);
   DCHECK(vbox);
   GList* hbox_list = gtk_container_get_children(GTK_CONTAINER(vbox));
   gint index = g_list_index(hbox_list, hbox);
   DCHECK(index != -1);
 
   return index;
 }
 
+// A gtk_container_foreach callback to enable/disable a widget.
+void EnableWidgetCallback(GtkWidget* widget, gpointer data) {
+  gtk_widget_set_sensitive(widget, *static_cast<gboolean*>(data));
+}
+
+// A gtk_container_foreach callback to show/hide the stars and install button
+// widgets of an extension hbox.
+void SetStarsAndIntallButtonVisibility(GtkWidget* extension_hbox,
+                                       gpointer data) {
+  gboolean visible = *static_cast<gboolean*>(data);
+  GList* list = gtk_container_get_children(GTK_CONTAINER(extension_hbox));
+  GtkWidget* stars = GTK_WIDGET(g_list_nth_data(list, kStarsIndex));
+  GtkWidget* install_button =
+      GTK_WIDGET(g_list_nth_data(list, kInstallButtonIndex));
+
+  if (visible) {
+    // Reset the size requisition to use the "natural" size.
+    gtk_widget_set_size_request(extension_hbox, -1, -1);
+    gtk_widget_show(stars);
+    gtk_widget_show(install_button);
+  } else {
+    GtkRequisition requisition;
+    gtk_widget_size_request(extension_hbox, &requisition);
+    gtk_widget_hide(stars);
+    gtk_widget_hide(install_button);
+    // Ask for the new size to be the same as before stuff was hidden.
+    gtk_widget_set_size_request(extension_hbox, requisition.width,
+                                requisition.height);
+  }
+}
+
 } // namespace
 
 // static
 WebIntentPicker* WebIntentPicker::Create(Browser* browser,
                                          TabContentsWrapper* wrapper,
                                          WebIntentPickerDelegate* delegate,
                                          WebIntentPickerModel* model) {
   return new WebIntentPickerGtk(browser, wrapper, delegate, model);
 }
 
@@ skipping 30 matching lines @@
 
 WebIntentPickerGtk::~WebIntentPickerGtk() {
 }
 
 void WebIntentPickerGtk::Close() {
   window_->CloseConstrainedWindow();
   if (inline_disposition_tab_contents_.get())
     inline_disposition_tab_contents_->web_contents()->OnCloseStarted();
 }
 
+void WebIntentPickerGtk::OnExtensionInstallSuccess(const std::string& id) {
+  RemoveThrobber();
+}
+
+void WebIntentPickerGtk::OnExtensionInstallFailure(const std::string& id) {
+  RemoveThrobber();
+  SetWidgetsEnabled(true);
+}
+
 void WebIntentPickerGtk::OnModelChanged(WebIntentPickerModel* model) {
   UpdateInstalledServices();
   UpdateCWSLabel();
   UpdateSuggestedExtensions();
 }
 
 void WebIntentPickerGtk::OnFaviconChanged(WebIntentPickerModel* model,
                                           size_t index) {
   UpdateInstalledServices();
 }
@@ skipping 106 matching lines @@
   GURL extension_url(extension_urls::GetWebstoreItemDetailURLPrefix() +
                      UTF16ToUTF8(extension.id));
   browser::NavigateParams params(browser_,
                                  extension_url,
                                  content::PAGE_TRANSITION_AUTO_BOOKMARK);
   params.disposition = NEW_FOREGROUND_TAB;
   browser::Navigate(&params);
 }
 
 void WebIntentPickerGtk::OnExtensionInstallButtonClick(GtkWidget* button) {
-  // TODO(binji): Install the extension.
+  size_t index = GetExtensionWidgetRow(button);
+  const WebIntentPickerModel::SuggestedExtension& extension =
+      model_->GetSuggestedExtensionAt(index);
+
+  delegate_->OnExtensionInstallRequested(UTF16ToUTF8(extension.id));
+  SetWidgetsEnabled(false);
+  // Re-enable the clicked extension row.
+  GList* vbox_list =
+      gtk_container_get_children(GTK_CONTAINER(extensions_vbox_));
+  GtkWidget* hbox = static_cast<GtkWidget*>(g_list_nth_data(vbox_list, index));
+  gboolean enabled = TRUE;
+  EnableWidgetCallback(hbox, &enabled);

[Evan Stade, 2012/03/30 21:38:25]

not really necessary; imo decreases readability as opposed to just making the
set_sensitive call from here

[binji, 2012/03/30 23:03:51]

Done.

+
+  AddThrobberToExtensionAt(index);
 }
 
 void WebIntentPickerGtk::OnMoreSuggestionsLinkClick(GtkWidget* link) {
   // TODO(binji): This should link to a CWS search, based on the current
   // action/type pair.
   browser::NavigateParams params(
       browser_,
       GURL(extension_urls::GetWebstoreLaunchURL()),
       content::PAGE_TRANSITION_AUTO_BOOKMARK);
   params.disposition = NEW_FOREGROUND_TAB;
@@ skipping 36 matching lines @@
       CustomDrawButton::CloseButton(GetThemeService(wrapper_)));
   g_signal_connect(close_button_->widget(),
                    "clicked",
                    G_CALLBACK(OnCloseButtonClickThunk),
                    this);
   gtk_widget_set_can_focus(close_button_->widget(), FALSE);
   gtk_box_pack_end(GTK_BOX(header_hbox), close_button_->widget(),
       FALSE, FALSE, 0);
 
   // Alignment for service button vbox.
-  GtkWidget* button_alignment = gtk_alignment_new(0.5f, 0.5f, 0.3f, 0);
+  GtkWidget* button_alignment = gtk_alignment_new(0, 0.5f, 0.3f, 0);
+  gtk_alignment_set_padding(GTK_ALIGNMENT(button_alignment), 0, 0,
+                            ui::kGroupIndent, 0);
   gtk_widget_set_no_show_all(button_alignment, TRUE);
 
   // Vbox containing all service buttons.
   button_vbox_ = gtk_vbox_new(FALSE, ui::kControlSpacing);
   gtk_container_add(GTK_CONTAINER(button_alignment), button_vbox_);
   gtk_box_pack_start(GTK_BOX(contents_), button_alignment, TRUE, TRUE, 0);
 
   // Chrome Web Store label.
   cws_label_ = theme_service->BuildLabel(
       l10n_util::GetStringUTF8(IDS_INTENT_PICKER_GET_MORE_SERVICES).c_str(),
       ui::kGdkBlack);
   gtk_box_pack_start(GTK_BOX(contents_), cws_label_, TRUE, TRUE, 0);
   gtk_misc_set_alignment(GTK_MISC(cws_label_), 0, 0);
   gtk_widget_set_no_show_all(cws_label_, TRUE);
   gtk_util::SetLabelWidth(cws_label_, kWebStoreLabelLength);
 
+  // Suggested extensions vbox.
+  extensions_vbox_ = gtk_vbox_new(FALSE, ui::kControlSpacing);
+  GtkWidget* indent_extensions = gtk_util::IndentWidget(extensions_vbox_);
+  gtk_widget_set_no_show_all(indent_extensions, TRUE);
+  gtk_box_pack_start(GTK_BOX(contents_), indent_extensions, TRUE, TRUE, 0);
+
+  // Left-aligned link button.
+  GtkWidget* link_alignment = gtk_alignment_new(0, 0.5f, 0, 0);
+  GtkWidget* more_suggestions_link = theme_service->BuildChromeLinkButton(
+      l10n_util::GetStringUTF8(IDS_INTENT_PICKER_MORE_SUGGESTIONS).c_str());
+  gtk_container_add(GTK_CONTAINER(link_alignment), more_suggestions_link);
+  gtk_chrome_link_button_set_use_gtk_theme(
+      GTK_CHROME_LINK_BUTTON(more_suggestions_link),
+      theme_service->UsingNativeTheme());

[Evan Stade, 2012/03/30 21:38:25]

AFAIK the picker is always natively themed (does the background ever change?)

[binji, 2012/03/30 23:03:51]

Yes, when I click through GTK themes, it changes the background.

[Evan Stade, 2012/03/31 01:24:35]

those are native themes. It is always natively themed. It never follows the
browser theme.

[binji, 2012/04/02 18:22:36]

OK, removed.

+  g_signal_connect(more_suggestions_link, "clicked",
+                   G_CALLBACK(OnMoreSuggestionsLinkClickThunk), this);
+  gtk_box_pack_start(GTK_BOX(contents_), link_alignment, FALSE, FALSE, 0);
+
+  // Throbber, which will be added to the heirarchy when necessary.

[Evan Stade, 2012/03/30 21:38:25]

sp.

[binji, 2012/03/30 23:03:51]

Done.

+  throbber_.reset(new ThrobberGtk(theme_service));
+
   g_signal_connect(contents_, "destroy", G_CALLBACK(&OnDestroyThunk), this);
-
-  // Suggested extensions vbox.
-  extensions_vbox_ = gtk_vbox_new(FALSE, ui::kContentAreaSpacing);
-  gtk_box_pack_start(GTK_BOX(contents_),
-                     gtk_util::IndentWidget(extensions_vbox_), TRUE, TRUE, 0);
 }
 
 void WebIntentPickerGtk::UpdateInstalledServices() {
   gtk_util::RemoveAllChildren(button_vbox_);
 
+  if (model_->GetInstalledServiceCount() == 0) {
+    gtk_widget_hide(gtk_widget_get_parent(button_vbox_));
+    return;
+  }
+
   for (size_t i = 0; i < model_->GetInstalledServiceCount(); ++i) {
     const WebIntentPickerModel::InstalledService& installed_service =
         model_->GetInstalledServiceAt(i);
 
     GtkWidget* button = gtk_button_new();
 
     gtk_widget_set_tooltip_text(button, installed_service.url.spec().c_str());
     gtk_button_set_label(GTK_BUTTON(button),
                          UTF16ToUTF8(installed_service.title).c_str());
     gtk_button_set_alignment(GTK_BUTTON(button), 0, 0);
 
     gtk_box_pack_start(GTK_BOX(button_vbox_), button, FALSE, FALSE, 0);
     g_signal_connect(button,
                      "clicked",
                      G_CALLBACK(OnServiceButtonClickThunk),
                      this);
 
     SetServiceButtonImage(button, installed_service.favicon.ToGdkPixbuf());
   }
 
   gtk_widget_show_all(button_vbox_);
+  gtk_widget_show(gtk_widget_get_parent(button_vbox_));
 }
 
 void WebIntentPickerGtk::UpdateCWSLabel() {
   if (model_->GetInstalledServiceCount() == 0) {
     gtk_widget_hide(gtk_widget_get_parent(button_vbox_));
     gtk_label_set_text(GTK_LABEL(cws_label_), l10n_util::GetStringUTF8(
         IDS_INTENT_PICKER_GET_MORE_SERVICES_NONE_INSTALLED).c_str());
   } else {
     gtk_label_set_text(GTK_LABEL(cws_label_),
         l10n_util::GetStringUTF8(IDS_INTENT_PICKER_GET_MORE_SERVICES).c_str());
     gtk_widget_show(gtk_widget_get_parent(button_vbox_));
   }
 
   if (model_->GetSuggestedExtensionCount() == 0)
     gtk_widget_hide(cws_label_);
   else
     gtk_widget_show(cws_label_);
 }
 
 void WebIntentPickerGtk::UpdateSuggestedExtensions() {
   ThemeServiceGtk* theme_service = GetThemeService(wrapper_);
 
   gtk_util::RemoveAllChildren(extensions_vbox_);
-  if (model_->GetSuggestedExtensionCount() == 0)
+
+  if (model_->GetSuggestedExtensionCount() == 0) {
+    gtk_widget_hide(gtk_widget_get_parent(extensions_vbox_));
     return;
+  }
+
+  gtk_widget_show(gtk_widget_get_parent(extensions_vbox_));
 
   for (size_t i = 0; i < model_->GetSuggestedExtensionCount(); ++i) {
     const WebIntentPickerModel::SuggestedExtension& extension =
         model_->GetSuggestedExtensionAt(i);
 
     GtkWidget* hbox = gtk_hbox_new(FALSE, ui::kControlSpacing);
     gtk_box_pack_start(GTK_BOX(extensions_vbox_), hbox, FALSE, FALSE, 0);
 
     // Icon.
     GtkWidget* icon = gtk_image_new_from_pixbuf(extension.icon.ToGdkPixbuf());
@@ skipping 19 matching lines @@
     // Install button.
     GtkWidget* install_button = gtk_button_new();
     gtk_button_set_label(
         GTK_BUTTON(install_button),
         l10n_util::GetStringUTF8(IDS_INTENT_PICKER_INSTALL_EXTENSION).c_str());
     g_signal_connect(install_button, "clicked",
                      G_CALLBACK(OnExtensionInstallButtonClickThunk), this);
     gtk_box_pack_end(GTK_BOX(hbox), install_button, FALSE, FALSE, 0);
   }
 
-  ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
+  gtk_widget_show_all(extensions_vbox_);
+  gtk_widget_show(gtk_widget_get_parent(extensions_vbox_));
+}
 
-  GtkWidget* hbox = gtk_hbox_new(FALSE, ui::kControlSpacing);
+void WebIntentPickerGtk::SetWidgetsEnabled(bool enabled) {
+  gboolean data = enabled;
+  gtk_container_foreach(GTK_CONTAINER(button_vbox_),
+                        EnableWidgetCallback,
+                        &data);
+  gtk_container_foreach(GTK_CONTAINER(extensions_vbox_),
+                        EnableWidgetCallback,
+                        &data);
+  gtk_container_foreach(GTK_CONTAINER(extensions_vbox_),
+                        SetStarsAndIntallButtonVisibility,
+                        &data);
+}
 
-  // Chrome Web Store icon.
-  gtk_box_pack_start(
-      GTK_BOX(hbox),
-      gtk_image_new_from_pixbuf(
-          rb.GetRTLEnabledPixbufNamed(IDR_WEBSTORE_ICON_16)),
-      FALSE, FALSE, 0);
+void WebIntentPickerGtk::AddThrobberToExtensionAt(size_t index) {
+  // The throbber should be unparented.
+  DCHECK(!gtk_widget_get_parent(throbber_->widget()));
+  GList* vbox_list =
+      gtk_container_get_children(GTK_CONTAINER(extensions_vbox_));
+  GtkWidget* hbox = static_cast<GtkWidget*>(g_list_nth_data(vbox_list, index));
+  GtkWidget* alignment = gtk_alignment_new(0, 0.5, 0, 0);
+  gtk_container_add(GTK_CONTAINER(alignment), throbber_->widget());
+  gtk_box_pack_start(GTK_BOX(hbox), alignment, FALSE, FALSE, 0);
+  gtk_widget_show_all(alignment);
+  throbber_->Start();
+}
 
-  // Left-aligned link button.
-  GtkWidget* more_suggestions_link = theme_service->BuildChromeLinkButton(
-      l10n_util::GetStringUTF8(IDS_INTENT_PICKER_MORE_SUGGESTIONS).c_str());
-  gtk_chrome_link_button_set_use_gtk_theme(
-      GTK_CHROME_LINK_BUTTON(more_suggestions_link),
-      theme_service->UsingNativeTheme());
-  g_signal_connect(more_suggestions_link, "clicked",
-                   G_CALLBACK(OnMoreSuggestionsLinkClickThunk), this);
-  gtk_box_pack_start(GTK_BOX(hbox), more_suggestions_link,
-                     FALSE, FALSE, 0);
-
-  gtk_box_pack_start(GTK_BOX(extensions_vbox_), hbox, FALSE, FALSE, 0);
-
-  gtk_widget_show_all(extensions_vbox_);
+void WebIntentPickerGtk::RemoveThrobber() {
+  GtkWidget* alignment = gtk_widget_get_parent(throbber_->widget());
+  DCHECK(alignment);
+  gtk_container_remove(GTK_CONTAINER(alignment), throbber_->widget());
+  gtk_widget_destroy(alignment);
+  throbber_->Stop();
 }
 
 GtkWidget* WebIntentPickerGtk::CreateStarsWidget(double rating) {
   const int kStarSpacing = 1;  // Spacing between stars in pixels.
   GtkWidget* hbox = gtk_hbox_new(FALSE, kStarSpacing);
 
   ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
   for (int i = 0; i < 5; ++i) {
     gtk_box_pack_start(
         GTK_BOX(hbox),
         gtk_image_new_from_pixbuf(rb.GetRTLEnabledPixbufNamed(
             WebIntentPicker::GetNthStarImageIdFromCWSRating(rating, i))),
         FALSE, FALSE, 0);
   }
 
   return hbox;
 }