Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 9836131: Remove PPB_Flash_NetConnector and ENABLE_FLAPPER_HACKS. (Closed)

Created:
8 years, 9 months ago by viettrungluu
Modified:
8 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews, jam, yzshen+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Remove PPB_Flash_NetConnector and ENABLE_FLAPPER_HACKS. PPB_Flash_NetConnector has been superseded by less hacky and more general interfaces. ENABLE_FLAPPER_HACKS only enabled PPB_Flash_NetConnector. TEST=builds (and still passes PPAPI tests) TBR=darin@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129444

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1237 lines) Patch
M build/common.gypi View 3 chunks +0 lines, -11 lines 0 comments Download
M content/browser/renderer_host/pepper_message_filter.h View 1 chunk +0 lines, -28 lines 0 comments Download
M content/browser/renderer_host/pepper_message_filter.cc View 3 chunks +0 lines, -178 lines 0 comments Download
M content/common/pepper_messages.h View 1 chunk +0 lines, -21 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.h View 2 chunks +0 lines, -16 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 3 chunks +0 lines, -50 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/render_view_impl.cc View 3 chunks +0 lines, -18 lines 0 comments Download
D ppapi/c/private/ppb_flash_net_connector.h View 1 chunk +0 lines, -46 lines 0 comments Download
D ppapi/cpp/private/flash_net_connector.h View 1 chunk +0 lines, -38 lines 0 comments Download
D ppapi/cpp/private/flash_net_connector.cc View 1 chunk +0 lines, -62 lines 0 comments Download
M ppapi/ppapi_proxy.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/ppapi_proxy_untrusted.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/ppapi_shared.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/ppapi_sources.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 2 chunks +0 lines, -20 lines 0 comments Download
D ppapi/proxy/ppb_flash_net_connector_proxy.h View 1 chunk +0 lines, -59 lines 0 comments Download
D ppapi/proxy/ppb_flash_net_connector_proxy.cc View 1 chunk +0 lines, -306 lines 0 comments Download
M ppapi/proxy/resource_creation_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/resource_creation_proxy.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M ppapi/shared_impl/api_id.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/shared_impl/resource.h View 1 chunk +0 lines, -1 line 0 comments Download
D ppapi/thunk/ppb_flash_net_connector_api.h View 1 chunk +0 lines, -33 lines 0 comments Download
D ppapi/thunk/ppb_flash_net_connector_thunk.cc View 1 chunk +0 lines, -73 lines 0 comments Download
M ppapi/thunk/resource_creation_api.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/thunk/thunk.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/mock_plugin_delegate.h View 1 chunk +0 lines, -7 lines 0 comments Download
M webkit/plugins/ppapi/mock_plugin_delegate.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M webkit/plugins/ppapi/plugin_delegate.h View 2 chunks +0 lines, -9 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 2 chunks +0 lines, -6 lines 0 comments Download
D webkit/plugins/ppapi/ppb_flash_net_connector_impl.h View 1 chunk +0 lines, -66 lines 0 comments Download
D webkit/plugins/ppapi/ppb_flash_net_connector_impl.cc View 1 chunk +0 lines, -132 lines 0 comments Download
M webkit/plugins/ppapi/resource_creation_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/resource_creation_impl.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
viettrungluu
This change adds 0 lines.
8 years, 9 months ago (2012-03-27 20:22:39 UTC) #1
brettw
lgtm
8 years, 9 months ago (2012-03-28 05:37:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/9836131/1
8 years, 9 months ago (2012-03-28 14:37:53 UTC) #3
commit-bot: I haz the power
Presubmit check for 9836131-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 9 months ago (2012-03-28 14:38:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/9836131/1
8 years, 9 months ago (2012-03-28 16:22:34 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-28 18:14:03 UTC) #6
Change committed as 129444

Powered by Google App Engine
This is Rietveld 408576698