Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 9836126: Add ShareGroup stub (Closed)

Created:
8 years, 9 months ago by greggman
Modified:
8 years, 9 months ago
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Add ShareGroup stub TEST=unit test BUG=120297 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129456

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -0 lines) Patch
A gpu/command_buffer/client/ref_counted.h View 1 1 chunk +24 lines, -0 lines 0 comments Download
A gpu/command_buffer/client/share_group.h View 1 1 chunk +32 lines, -0 lines 0 comments Download
A gpu/command_buffer/client/share_group.cc View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
A gpu/command_buffer/client/share_group_unittest.cc View 1 1 chunk +35 lines, -0 lines 0 comments Download
M gpu/gpu.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/gpu_common.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/nacl.scons View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/ppapi_proxy_untrusted.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
greggman
Hey Nicholas, PTAL I just wanted to get this in so the NaCl integration is ...
8 years, 9 months ago (2012-03-27 19:15:05 UTC) #1
nfullagar
lgtm
8 years, 9 months ago (2012-03-27 19:34:18 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 9 months ago (2012-03-27 19:58:18 UTC) #3
greggman
Hey Al, PTAL. Nicholas already reviewed but apparently he's not marked as a committer?
8 years, 9 months ago (2012-03-27 20:15:41 UTC) #4
apatrick_chromium
http://codereview.chromium.org/9836126/diff/1/gpu/command_buffer/client/share_group.h File gpu/command_buffer/client/share_group.h (right): http://codereview.chromium.org/9836126/diff/1/gpu/command_buffer/client/share_group.h#newcode9 gpu/command_buffer/client/share_group.h:9: #include "../common/scoped_ptr.h" scoped_ptr is not used. http://codereview.chromium.org/9836126/diff/1/gpu/command_buffer/client/share_group.h#newcode16 gpu/command_buffer/client/share_group.h:16: class ...
8 years, 9 months ago (2012-03-27 21:29:17 UTC) #5
greggman
http://codereview.chromium.org/9836126/diff/1/gpu/command_buffer/client/share_group.h File gpu/command_buffer/client/share_group.h (right): http://codereview.chromium.org/9836126/diff/1/gpu/command_buffer/client/share_group.h#newcode9 gpu/command_buffer/client/share_group.h:9: #include "../common/scoped_ptr.h" On 2012/03/27 21:29:17, apatrick_chromium wrote: > scoped_ptr ...
8 years, 9 months ago (2012-03-27 21:47:22 UTC) #6
apatrick_chromium
lgtm
8 years, 9 months ago (2012-03-27 22:08:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/9836126/5002
8 years, 9 months ago (2012-03-28 00:27:40 UTC) #8
commit-bot: I haz the power
Try job failure for 9836126-5002 on win_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=14838 Step "update" is always ...
8 years, 9 months ago (2012-03-28 00:32:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/9836126/5004
8 years, 9 months ago (2012-03-28 08:17:24 UTC) #10
commit-bot: I haz the power
Try job failure for 9836126-5004 on win for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=4818 Step "update" is always ...
8 years, 9 months ago (2012-03-28 08:26:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/9836126/5004
8 years, 9 months ago (2012-03-28 16:08:03 UTC) #12
commit-bot: I haz the power
8 years, 9 months ago (2012-03-28 19:04:58 UTC) #13
Change committed as 129456

Powered by Google App Engine
This is Rietveld 408576698