Fix base::CPU detection.

Fix base::CPU detection.

ARCH_CPU_X86_FAMILY was never being defined, causing base::CPU::Initialize to be a no-op.


BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=130046

[willchan no longer on Chromium, 2012-03-28 00:46:31]

I'm at IETF in Paris. Jim, can you review instead? Thanks.

[jar (doing other things), 2012-03-28 18:46:56]

https://chromiumcodereview.appspot.com/9836125/diff/7001/base/time_win_unitte...
File base/time_win_unittest.cc (right):

https://chromiumcodereview.appspot.com/9836125/diff/7001/base/time_win_unitte...
base/time_win_unittest.cc:233: EXPECT_LT(0, total_drift);
This seems like a high-risk flaky test.

In addition, why don't we just bail at the start of the test when we don't have
a HighResClock?

[jbauman, 2012-03-28 22:52:05]

On 2012/03/28 18:46:56, jar wrote:
>
https://chromiumcodereview.appspot.com/9836125/diff/7001/base/time_win_unitte...
> File base/time_win_unittest.cc (right):
> 
>
https://chromiumcodereview.appspot.com/9836125/diff/7001/base/time_win_unitte...
> base/time_win_unittest.cc:233: EXPECT_LT(0, total_drift);
> This seems like a high-risk flaky test.

You would think so, but the test is still enabled, I guess.
> 
> In addition, why don't we just bail at the start of the test when we don't
have
> a HighResClock?

Ok, sure. Fixed.

[jar (doing other things), 2012-03-29 01:30:59]

lgtm

[commit-bot: I haz the power, 2012-03-29 22:57:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jbauman@chromium.org/9836125/16001

[commit-bot: I haz the power, 2012-03-30 01:42:03]

Try job failure for 9836125-16001 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-03-31 05:19:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jbauman@chromium.org/9836125/16001

[commit-bot: I haz the power, 2012-03-31 07:08:55]

Change committed as 130046