Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 9836122: Check that an instance variable is non-NULL before use. (Closed)

Created:
8 years, 9 months ago by Kyle Horimoto
Modified:
8 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, dcheng
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Check that an instance variable is non-NULL before use. CID=103659 BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129478

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/views/tabs/tab_drag_controller2.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Kyle Horimoto
8 years, 9 months ago (2012-03-27 21:29:20 UTC) #1
sky
LGTM
8 years, 9 months ago (2012-03-27 21:38:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khorimoto@chromium.org/9836122/1
8 years, 9 months ago (2012-03-27 22:49:02 UTC) #3
commit-bot: I haz the power
Presubmit check for 9836122-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 9 months ago (2012-03-27 22:49:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khorimoto@chromium.org/9836122/1
8 years, 9 months ago (2012-03-27 23:03:43 UTC) #5
commit-bot: I haz the power
The commit queue went berserk retrying too often for a seemingly flaky test. Builder is ...
8 years, 9 months ago (2012-03-28 00:27:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khorimoto@chromium.org/9836122/1
8 years, 9 months ago (2012-03-28 00:33:33 UTC) #7
commit-bot: I haz the power
Try job failure for 9836122-1 (retry) on win_rel for steps "ui_tests, browser_tests". It's a second ...
8 years, 9 months ago (2012-03-28 02:10:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/khorimoto@chromium.org/9836122/1
8 years, 9 months ago (2012-03-28 16:54:36 UTC) #9
commit-bot: I haz the power
8 years, 9 months ago (2012-03-28 20:24:07 UTC) #10
Change committed as 129478

Powered by Google App Engine
This is Rietveld 408576698