Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(901)

Issue 9836106: C++ code generated by generate_bindings.py was assigning a variable withing in if() statement (Visu… (Closed)

Created:
8 years, 8 months ago by trprice
Modified:
8 years, 8 months ago
CC:
chromium-reviews, dhollowa+watch_chromium.org
Visibility:
Public.

Description

C++ code generated by generate_bindings.py was assigning a variable withing in if() statement (Visual Studio 2010 warning C4706). I moved the assignment of the variable to the line before the if() statement so that the assignment of the variable happens outside of the if() statement. Additionally, I added myself to the AUTHORS file. I filled out the Contributor License Agreement a while back, but didn't add myself to AUTHORS at that point. BUG=chromium:81439 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129479

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/gl/generate_bindings.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
trprice
Good Evening, To work on issue 81439, I turned on warning level 4 for VS ...
8 years, 8 months ago (2012-03-27 05:08:43 UTC) #1
apatrick_chromium
LGTM and thanks. I don't see your name in the AUTHORs file. Have you filled ...
8 years, 8 months ago (2012-03-27 17:29:19 UTC) #2
trprice
You're welcome. I have filled out the Contributor License Agreement but neglected to add myself ...
8 years, 8 months ago (2012-03-27 19:14:24 UTC) #3
trprice
I added myself to the AUTHORS file, changed the changelist, and re-uploaded it. I filled ...
8 years, 8 months ago (2012-03-28 04:35:02 UTC) #4
M-A Ruel
Verified CLA, queueing the CL for CQ.
8 years, 8 months ago (2012-03-28 12:33:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/trprice@gmail.com/9836106/3001
8 years, 8 months ago (2012-03-28 12:33:29 UTC) #6
commit-bot: I haz the power
Try job failure for 9836106-3001 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 8 months ago (2012-03-28 14:51:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/trprice@gmail.com/9836106/3001
8 years, 8 months ago (2012-03-28 14:52:21 UTC) #8
commit-bot: I haz the power
Try job failure for 9836106-3001 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 8 months ago (2012-03-28 18:18:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/trprice@gmail.com/9836106/3001
8 years, 8 months ago (2012-03-28 18:24:18 UTC) #10
commit-bot: I haz the power
8 years, 8 months ago (2012-03-28 20:30:18 UTC) #11
Change committed as 129479

Powered by Google App Engine
This is Rietveld 408576698