Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3162)

Unified Diff: chrome/browser/ui/webui/history_ui.cc

Issue 9836103: Fix most remaining WebUI link errors on Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: atwilson's comments Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/history_ui.cc
diff --git a/chrome/browser/ui/webui/history_ui.cc b/chrome/browser/ui/webui/history_ui.cc
index 1ed03af9e0e04477edf36449c89b811eb550015f..ed19d5d1406e40baa0ceeb3340f73ea48d08fb62 100644
--- a/chrome/browser/ui/webui/history_ui.cc
+++ b/chrome/browser/ui/webui/history_ui.cc
@@ -259,12 +259,16 @@ void BrowsingHistoryHandler::HandleRemoveURLsOnOneDay(const ListValue* args) {
}
void BrowsingHistoryHandler::HandleClearBrowsingData(const ListValue* args) {
+#if defined(OS_ANDROID)
+ NOTIMPLEMENTED() << "TODO(yfriedman): Upstream the Android version.";
battre 2012/03/27 18:54:30 Does the string end in the release binary? In that
Yaron 2012/03/27 19:06:52 I don't believe it ends up in a release binary and
+#else
// TODO(beng): This is an improper direct dependency on Browser. Route this
// through some sort of delegate.
Profile* profile = Profile::FromWebUI(web_ui());
Browser* browser = BrowserList::FindBrowserWithProfile(profile);
if (browser)
browser->OpenClearBrowsingDataDialog();
+#endif
}
void BrowsingHistoryHandler::QueryComplete(

Powered by Google App Engine
This is Rietveld 408576698