Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc

Issue 9836103: Fix most remaining WebUI link errors on Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/profile_sync_service.cc ('k') | chrome/browser/ui/webui/history_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
diff --git a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
index f960d372165ef9947df7cbaa501eac43551d9491..4ec89b796970499fae5961af4f62cfd1cfbb89c6 100644
--- a/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
+++ b/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
@@ -182,8 +182,6 @@ WebUIFactoryFunction GetWebUIFactoryFunction(content::WebUI* web_ui,
return &NewWebUI<ConstrainedHtmlUI>;
if (url.host() == chrome::kChromeUIExtensionsFrameHost)
return &NewWebUI<ExtensionsUI>;
- if (url.host() == chrome::kChromeUIFlagsHost)
- return &NewWebUI<FlagsUI>;
if (url.host() == chrome::kChromeUIFlashHost)
return &NewWebUI<FlashUI>;
if (url.host() == chrome::kChromeUIGpuInternalsHost)
@@ -218,8 +216,6 @@ WebUIFactoryFunction GetWebUIFactoryFunction(content::WebUI* web_ui,
return &NewWebUI<UberFrameUI>;
if (url.host() == chrome::kChromeUIUberHost)
return &NewWebUI<UberUI>;
- if (url.host() == chrome::kChromeUIInspectHost)
- return &NewWebUI<InspectUI>;
/****************************************************************************
* OS Specific #defines
@@ -228,13 +224,20 @@ WebUIFactoryFunction GetWebUIFactoryFunction(content::WebUI* web_ui,
// These pages are implemented with native UI elements on Android.
if (url.host() == chrome::kChromeUIDownloadsHost)
return &NewWebUI<DownloadsUI>;
- // Android doesn't use the Options pages.
if (url.host() == chrome::kChromeUIFeedbackHost)
return &NewWebUI<FeedbackUI>;
if (url.host() == chrome::kChromeUIHelpFrameHost)
return &NewWebUI<HelpUI>;
if (url.host() == chrome::kChromeUISettingsFrameHost)
return &NewWebUI<options2::OptionsUI>;
+ // chrome://flags is currently unsupported on Android.
+ if (url.host() == chrome::kChromeUIFlagsHost)
+ return &NewWebUI<FlagsUI>;
+ // chrome://inspect isn't supported on Android. Page debugging is handled by a
+ // remote devtools on the host machine, and other elements (Shared Workers,
+ // extensions, etc) aren't supported.
+ if (url.host() == chrome::kChromeUIInspectHost)
+ return &NewWebUI<InspectUI>;
// Android doesn't support print/print-preview.
if (url.host() == chrome::kChromeUIPrintHost &&
!g_browser_process->local_state()->GetBoolean(
@@ -470,9 +473,6 @@ RefCountedMemory* ChromeWebUIControllerFactory::GetFaviconResourceBytes(
if (page_url.host() == chrome::kChromeUIHistoryHost)
return HistoryUI::GetFaviconResourceBytes();
- if (page_url.host() == chrome::kChromeUIFlagsHost)
- return FlagsUI::GetFaviconResourceBytes();
-
if (page_url.host() == chrome::kChromeUISessionsHost)
return SessionsUI::GetFaviconResourceBytes();
@@ -484,6 +484,10 @@ RefCountedMemory* ChromeWebUIControllerFactory::GetFaviconResourceBytes(
if (page_url.host() == chrome::kChromeUIDownloadsHost)
return DownloadsUI::GetFaviconResourceBytes();
+ // chrome://flags is currently unsupported on Android.
+ if (page_url.host() == chrome::kChromeUIFlagsHost)
+ return FlagsUI::GetFaviconResourceBytes();
+
// Android doesn't use the Options pages.
if (page_url.host() == chrome::kChromeUISettingsFrameHost)
return options2::OptionsUI::GetFaviconResourceBytes();
« no previous file with comments | « chrome/browser/sync/profile_sync_service.cc ('k') | chrome/browser/ui/webui/history_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698