Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4223)

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 9836103: Fix most remaining WebUI link errors on Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove about_flags Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/prefs/browser_prefs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_browser_main.cc
diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc
index 6413b349932f26dbe22459226e5253a616d41966..7c0badd684cccf9b1eca09d63cdd0099f5d395a5 100644
--- a/chrome/browser/chrome_browser_main.cc
+++ b/chrome/browser/chrome_browser_main.cc
@@ -1294,9 +1294,12 @@ int ChromeBrowserMainParts::PreCreateThreadsImpl() {
if (!parsed_command_line().HasSwitch(switches::kNoErrorDialogs))
WarnAboutMinimumSystemRequirements();
- // Convert active labs into switches. Modifies the current command line.
+#if !defined(OS_ANDROID)
+ // Convert active labs into switches. Modifies the current command line. Not
+ // needed on Android as there aren't experimental flags.
about_flags::ConvertFlagsToSwitches(local_state_,
CommandLine::ForCurrentProcess());
+#endif
local_state_->UpdateCommandLinePrefStore(CommandLine::ForCurrentProcess());
Yaron 2012/03/27 19:06:52 It's not clear to me if this should be in the if-d
// Reset the command line in the crash report details, since we may have
@@ -1706,7 +1709,9 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
HandleTestParameters(parsed_command_line());
RecordBreakpadStatusUMA(browser_process_->metrics_service());
+#if !defined(OS_ANDROID)
about_flags::RecordUMAStatistics(local_state_);
+#endif
LanguageUsageMetrics::RecordAcceptLanguages(
profile_->GetPrefs()->GetString(prefs::kAcceptLanguages));
LanguageUsageMetrics::RecordApplicationLanguage(
« no previous file with comments | « no previous file | chrome/browser/prefs/browser_prefs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698