Fix most remaining WebUI link errors on Android.

chrome/browser/sync/profile_sync_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/profile_sync_service.h"
 
 #include <cstddef>
 #include <map>
 #include <set>
 #include <utility>
@@ skipping 947 matching lines @@
       break;
     case browser_sync::DISABLE_SYNC_ON_CLIENT:
       OnStopSyncingPermanently();
       break;
     default:
       NOTREACHED();
   }
   NotifyObservers();
 }
 
 void ProfileSyncService::ShowErrorUI() {

[Andrew T Wilson (Slow), 2012/03/27 17:33:16]

Might as well put a NOTREACHED here for android. This routine will go away soon
anyway as part of moving all the UI stuff out of ProfileSyncService.

[Yaron, 2012/03/27 19:06:52]

Done.

+#if !defined(OS_ANDROID)
+  // Android uses native UI for sync setup.
   // TODO(atwilson): Remove this.
   LoginUIServiceFactory::GetForProfile(profile_)->ShowLoginUI(false);
+#endif
 }
 
 std::string ProfileSyncService::QuerySyncStatusSummary() {
   if (unrecoverable_error_detected_) {
     return "Unrecoverable error detected";
   } else if (!backend_.get()) {
     return "Syncing not enabled";
   } else if (backend_.get() && !HasSyncSetupCompleted()) {
     return "First time sync setup incomplete";
   } else if (backend_.get() && HasSyncSetupCompleted() &&
@@ skipping 629 matching lines @@
   // See http://stackoverflow.com/questions/6224121/is-new-this-myclass-undefined-behaviour-after-directly-calling-the-destru.
   ProfileSyncService* old_this = this;
   this->~ProfileSyncService();
   new(old_this) ProfileSyncService(
       new ProfileSyncComponentsFactoryImpl(profile,
                                            CommandLine::ForCurrentProcess()),
       profile,
       signin,
       behavior);
 }