Add full text regex searching to chrome://sync

chrome/browser/sync/internal_api/syncapi_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Unit tests for the SyncApi. Note that a lot of the underlying
 // functionality is provided by the Syncable layer, which has its own
 // unit tests. We'll test SyncApi specific things in this harness.
 
 #include <cstddef>
 #include <map>
@@ skipping 1187 matching lines @@
   }
 
   {
     ListValue args;
     args.Append(Value::CreateStringValue("9999"));
     SendJsMessage("getChildNodeIds",
                   JsArgList(&args), reply_handler.AsWeakHandle());
   }
 }
 
-// TODO(akalin): Add unit tests for findNodesContainingString message.
+TEST_F(SyncManagerTest, GetAllNodesTest) {
+  StrictMock<MockJsReplyHandler> reply_handler;
+  JsArgList return_args;
+
+  EXPECT_CALL(reply_handler,
+              HandleJsReply("getAllNodes", _))
+      .Times(1).WillRepeatedly(SaveArg<1>(&return_args));
+
+  {
+    ListValue args;
+    SendJsMessage("getAllNodes",
+                  JsArgList(&args), reply_handler.AsWeakHandle());
+  }
+
+  // There's not much value in verifying every attribute on every node here.
+  // Most of the value of this test has already been achieved: we've verified we
+  // can call the above function without crashing or leaking memory.
+  //
+  // Let's just check the list size and a few of its elements.  Anything more
+  // would make this test brittle without greatly increasing our chances of
+  // catching real bugs.
+
+  ListValue* node_list;
+  DictionaryValue* first_result;
+
+  // The resulting argument list should have one argument, a list of nodes.
+  ASSERT_EQ(return_args.Get().GetSize(), static_cast<size_t>(1));

[tim (not reviewing), 2012/04/12 01:22:08]

Here and below -

Prefer 1U to static_cast<size_t>(1).
Also, format is ASSERT_EQ(expected, actual), so I think you want to swap these. 

[rlarocque, 2012/04/12 02:27:19]

Done.

+  ASSERT_TRUE(return_args.Get().GetList(0, &node_list));
+
+  // The database creation logic depends on the routing info.
+  // Refer to setup methods for more information.
+  ModelSafeRoutingInfo routes;
+  GetModelSafeRoutingInfo(&routes);
+  size_t directory_size = routes.size() + 1;
+
+  ASSERT_EQ(node_list->GetSize(), directory_size);
+  ASSERT_TRUE(node_list->GetDictionary(0, &first_result));
+  EXPECT_TRUE(first_result->HasKey("ID"));
+  EXPECT_TRUE(first_result->HasKey("NON_UNIQUE_NAME"));
+}
 
 TEST_F(SyncManagerTest, OnNotificationStateChange) {
   InSequence dummy;
   StrictMock<MockJsEventHandler> event_handler;
 
   DictionaryValue true_details;
   true_details.SetBoolean("enabled", true);
   DictionaryValue false_details;
   false_details.SetBoolean("enabled", false);
 
@@ skipping 1215 matching lines @@
     EXPECT_EQ(title, node.GetTitle());
     EXPECT_EQ(GURL(url2), node.GetURL());
     const syncable::Entry* node_entry = node.GetEntry();
     EXPECT_EQ(kEncryptedString, node_entry->Get(NON_UNIQUE_NAME));
     const sync_pb::EntitySpecifics& specifics = node_entry->Get(SPECIFICS);
     EXPECT_TRUE(specifics.has_encrypted());
   }
 }
 
 }  // namespace browser_sync