Add full text regex searching to chrome://sync

chrome/browser/resources/sync_internals/sync_search.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // require: cr.js
 
 cr.define('chrome.sync', function() {
   var currSearchId = 0;
 
   /**
    * Runs a search with the given query.
    *
-   * @param {string} query The query to do the search with.
-   * @param {Array.<{id: string, title: string, isFolder: boolean}>}
+   * @param {string} query The regex to do the search with.
+   * @param {Array.<NodeSummary>}

[Andrew T Wilson (Slow), 2012/04/06 20:30:57]

Put the word "callback" on this line since it fits now. Also, is |callback| an
actual Array of NodeSummary objects? Because it looks like |callback| is
actually a Function.

[rlarocque, 2012/04/07 00:58:04]

You're right.  It wasn't always that way, but the comment got stale after a
series of attempts to refactor this function.  Will fix.

    *     callback The callback called with the search results; not
    *     called if doSearch() is called again while the search is
    *     running.
    */
   var doSearch = function(query, callback) {
     var searchId = ++currSearchId;
-    chrome.sync.findNodesContainingString(query, function(ids) {
-      if (currSearchId != searchId) {
-        return;
-      }
-      chrome.sync.getNodeSummariesById(ids, function(nodeSummaries) {
+    try {
+      var regex = new RegExp(query);
+      chrome.sync.getAllNodes(query, function(allNodes) {
         if (currSearchId != searchId) {
           return;
         }
-        callback(nodeSummaries);
+        callback(allNodes.filter(function(elem) {
+          return regex.test(JSON.stringify(elem, null, 2));

[Andrew T Wilson (Slow), 2012/04/06 20:30:57]

One quick question - is this fast enough to not trigger the "script on this page
is slow" dialog even for large data sets?

[rlarocque, 2012/04/07 00:58:04]

It depends how you define large.  I think my test, 5000 entries, is reasonably
large.  I'm aware that there are worse data sets out there, though.

I haven't ever seen that popup while testing in either debug or release builds. 
The slowest response I've seen was over 10 seconds on a debug build, but I think
most of that time was spent waiting for the callback and therefore didn't count
towards the timeout.

+        }), null);
       });
-    });
+    } catch (err) {
+      // Sometimes the provided regex is invalid.  This and other errors will
+      // be caught and handled here.
+      callback([], err);
+    }
   };
 
   /**
    * Decorates the various search controls.
    *
    * @param {!HTMLInputElement} queryControl The <input> object of
    *     type=search where the user types in his query.
    * @param {!HTMLElement} statusControl The <span> object display the
    *     search status.
    * @param {!HTMLElement} listControl The <list> object which holds
    *     the list of returned results.
    * @param {!HTMLPreElement} detailsControl The <pre> object which
    *     holds the details of the selected result.
    */
   function decorateSearchControls(queryControl, statusControl,
                                   resultsControl, detailsControl) {
     var resultsDataModel = new cr.ui.ArrayDataModel([]);
 
     // Decorate search box.
     queryControl.onsearch = function() {
       var query = queryControl.value;
       statusControl.textContent = '';
       resultsDataModel.splice(0, resultsDataModel.length);
       if (!query) {
         return;
       }
       statusControl.textContent = 'Searching for ' + query + '...';
+      queryControl.removeAttribute('error');
       var timer = chrome.sync.makeTimer();
-      doSearch(query, function(nodeSummaries) {
-        statusControl.textContent =
-          'Found ' + nodeSummaries.length + ' nodes in '
-          + timer.elapsedSeconds + 's';
-        // TODO(akalin): Write a nicer list display.
-        for (var i = 0; i < nodeSummaries.length; ++i) {
-          nodeSummaries[i].toString = function() {
-            return this.title;
-          }.bind(nodeSummaries[i]);
+      doSearch(query, function(nodes, error) {
+        if (error) {
+          statusControl.textContent = 'Error: ' + error;
+          queryControl.setAttribute('error');
+        } else {
+          statusControl.textContent =
+            'Found ' + nodes.length + ' nodes in '

[Andrew T Wilson (Slow), 2012/04/06 20:30:57]

nit: move + from next line to be on this line.

[rlarocque, 2012/04/07 00:58:04]

Done.

+            + timer.elapsedSeconds + 's';
+          queryControl.removeAttribute('error');
+
+          // TODO(akalin): Write a nicer list display.
+          for (var i = 0; i < nodes.length; ++i) {
+            nodes[i].toString = function() {
+              return this.NON_UNIQUE_NAME;
+            }.bind(nodes[i]);

[Andrew T Wilson (Slow), 2012/04/06 20:30:57]

Is this bind actually necessary (is the function invoked as a function, like
this:

var a = nodes[i].toString;
a();

or like this:
nodes[i].toString();

Because if it's invoked as an object invocation, then |this| will be properly
set without bind().

[rlarocque, 2012/04/07 00:58:04]

Done.

I tried a more clever solution, but it failed.  It looks like omitting the bind
works just fine.  

+          }
+          resultsDataModel.push.apply(resultsDataModel, nodes);
+          // Workaround for http://crbug.com/83452 .
+          resultsControl.redraw();
         }
-        resultsDataModel.push.apply(resultsDataModel, nodeSummaries);
-        // Workaround for http://crbug.com/83452 .
-        resultsControl.redraw();
       });
     };
     queryControl.value = '';
 
     // Decorate results list.
     cr.ui.List.decorate(resultsControl);
     resultsControl.dataModel = resultsDataModel;
     resultsControl.selectionModel.addEventListener('change', function(event) {
       detailsControl.textContent = '';
       var selected = resultsControl.selectedItem;
       if (selected) {
-        chrome.sync.getNodeDetailsById([selected.id], function(nodeDetails) {
-          var selectedNodeDetails = nodeDetails[0] || null;
-          if (selectedNodeDetails) {
-            detailsControl.textContent =
-              JSON.stringify(selectedNodeDetails, null, 2);
-          }
-        });
+        detailsControl.textContent = JSON.stringify(selected, null, 2);
       }
     });
   }
 
   return {
     decorateSearchControls: decorateSearchControls
   };
 });