Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 9836098: Move gpu hash_tables and atomicops stuff (Closed)

Created:
8 years, 9 months ago by greggman
Modified:
8 years, 9 months ago
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Move gpu hash_tables and atomicops stuff TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129341

Patch Set 1 #

Patch Set 2 : add atomic ops #

Patch Set 3 : tr1 -> std::tr1 #

Total comments: 1

Patch Set 4 : add hash tables to gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -18 lines) Patch
A gpu/command_buffer/client/atomicops.h View 1 1 chunk +14 lines, -0 lines 0 comments Download
A gpu/command_buffer/client/atomicops.cc View 1 1 chunk +22 lines, -0 lines 0 comments Download
A gpu/command_buffer/client/hash_tables.h View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/query_tracker.h View 1 2 chunks +2 lines, -10 lines 0 comments Download
M gpu/command_buffer/client/query_tracker.cc View 1 2 chunks +2 lines, -8 lines 0 comments Download
M gpu/command_buffer_client.gypi View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/nacl.scons View 1 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/ppapi_proxy_untrusted.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
greggman
Hey Nicholas, PTAL
8 years, 9 months ago (2012-03-27 19:11:05 UTC) #1
nfullagar
one Q otherwise lgtm if trybots green http://codereview.chromium.org/9836098/diff/5/gpu/command_buffer_client.gypi File gpu/command_buffer_client.gypi (right): http://codereview.chromium.org/9836098/diff/5/gpu/command_buffer_client.gypi#newcode22 gpu/command_buffer_client.gypi:22: 'command_buffer/client/fenced_allocator.h', hash_tables.h ...
8 years, 9 months ago (2012-03-27 19:30:48 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 9 months ago (2012-03-27 19:58:08 UTC) #3
greggman
Hey Al, PTAL. Nicholas already reviewed but apparently he's not marked as a committer?
8 years, 9 months ago (2012-03-27 20:16:07 UTC) #4
apatrick_chromium
lgtm
8 years, 9 months ago (2012-03-27 21:13:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/9836098/6002
8 years, 9 months ago (2012-03-27 22:48:22 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-28 02:08:29 UTC) #7
Change committed as 129341

Powered by Google App Engine
This is Rietveld 408576698