Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 9836078: Make json_schema_compiler output types in their dependency order. (Closed)

Created:
8 years, 9 months ago by Garret Kelly
Modified:
8 years, 9 months ago
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Make json_schema_compiler output types in their dependency order. Since fields are generated as simple structure elements the schema compiler must output the full definitions for structures that are depended-upon before the structures that depend upon them. This patch also causes same-namespace forward struct delcarations to be emitted to resolve circular dependencies and optional-property dependencies in generated code. BUG=119911 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=129042

Patch Set 1 #

Patch Set 2 : Do not generate forward declarations for non-struct types #

Total comments: 1

Patch Set 3 : Changing error message to make it clear that circular dependencies are forbidden. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M tools/json_schema_compiler/cpp_type_generator.py View 1 1 chunk +5 lines, -0 lines 0 comments Download
M tools/json_schema_compiler/h_generator.py View 1 2 2 chunks +21 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Garret Kelly
8 years, 9 months ago (2012-03-24 04:35:19 UTC) #1
asargent_no_longer_on_chrome
This is great! Thanks for taking it on. http://codereview.chromium.org/9836078/diff/3001/tools/json_schema_compiler/h_generator.py File tools/json_schema_compiler/h_generator.py (right): http://codereview.chromium.org/9836078/diff/3001/tools/json_schema_compiler/h_generator.py#newcode98 tools/json_schema_compiler/h_generator.py:98: raise ...
8 years, 9 months ago (2012-03-26 17:40:35 UTC) #2
miket_OOO
LGTM. I incorporate Antony's enthusiasm by reference here.
8 years, 9 months ago (2012-03-26 17:48:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gdk@chromium.org/9836078/8001
8 years, 9 months ago (2012-03-26 18:24:25 UTC) #4
commit-bot: I haz the power
Try job failure for 9836078-8001 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-26 21:05:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gdk@chromium.org/9836078/8001
8 years, 9 months ago (2012-03-26 21:09:34 UTC) #6
commit-bot: I haz the power
8 years, 9 months ago (2012-03-26 23:19:26 UTC) #7
Change committed as 129042

Powered by Google App Engine
This is Rietveld 408576698