Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 9836038: roll clang 151385:153254 (Closed)

Created:
8 years, 9 months ago by Nico
Modified:
8 years, 9 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, fischman+watch_chromium.org, pam+watch_chromium.org, ukai+watch_chromium.org, hans
Visibility:
Public.

Description

roll clang 151385:153254 New stuff: * ObjC number, array, dict literals * ASan fixes, visibility fixes (see bugs) * (c++11: User-defined literals) * -Wstring-plus-int * Fix for a bug that made the last roll not work with goma BUG=114996, 112539, 119119 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128696

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M build/common.gypi View 1 2 chunks +8 lines, -0 lines 1 comment Download
M tools/clang/scripts/update.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Nico
This took a bit longer this week, so hans is probably not around to review.
8 years, 9 months ago (2012-03-23 20:23:04 UTC) #1
Nico
http://codereview.chromium.org/9836038/diff/3001/build/common.gypi File build/common.gypi (right): http://codereview.chromium.org/9836038/diff/3001/build/common.gypi#newcode2058 build/common.gypi:2058: '-Wno-null-conversion', (This is in progress at http://codereview.chromium.org/9845017/)
8 years, 9 months ago (2012-03-23 20:25:31 UTC) #2
Mark Mentovai
Where’s the archived build log?
8 years, 9 months ago (2012-03-23 20:45:15 UTC) #3
Nico
On 2012/03/23 20:45:15, Mark Mentovai wrote: > Where’s the archived build log? Of the clang ...
8 years, 9 months ago (2012-03-23 20:47:35 UTC) #4
Mark Mentovai
No, that’s fine, that’s all I wanted to see. LGTM.
8 years, 9 months ago (2012-03-23 20:53:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9836038/3001
8 years, 9 months ago (2012-03-23 21:07:45 UTC) #6
commit-bot: I haz the power
Try job failure for 9836038-3001 (retry) on mac_rel for step "update". It's a second try, ...
8 years, 9 months ago (2012-03-23 23:31:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9836038/3001
8 years, 9 months ago (2012-03-23 23:39:41 UTC) #8
commit-bot: I haz the power
Try job failure for 9836038-3001 (retry) on linux_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-24 00:56:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9836038/3001
8 years, 9 months ago (2012-03-24 02:03:51 UTC) #10
commit-bot: I haz the power
8 years, 9 months ago (2012-03-24 05:57:55 UTC) #11
Change committed as 128696

Powered by Google App Engine
This is Rietveld 408576698