Issue 9835068: Don't delete Primary root window and monitor

Issue 9835068: Don't delete Primary root window and monitor (Closed)

Created:
8 years, 9 months ago by oshima

Modified:
8 years, 9 months ago

Reviewers:
Daniel Erat

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't delete Primary monitor and it's root window when # of monitors goes zero. BUG=none TEST=nonoe Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128684 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128786

Patch Set 4 : addressed comments #

Patch Set 6 : sync #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -6 lines)			Patch
M	ash/monitor/monitor_controller.cc	View	1 2 3 4	2 chunks	+14 lines, -2 lines	0 comments	Download
M	ash/monitor/multi_monitor_manager.cc	View	1 2 3 4 5	1 chunk	+6 lines, -2 lines	0 comments	Download
M	ash/monitor/multi_monitor_manager_unittest.cc	View	1 2 3 4	6 chunks	+56 lines, -2 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Daniel Erat

LGTM w/nits http://codereview.chromium.org/9835068/diff/3005/ash/monitor/multi_monitor_manager.h File ash/monitor/multi_monitor_manager.h (right): http://codereview.chromium.org/9835068/diff/3005/ash/monitor/multi_monitor_manager.h#newcode70 ash/monitor/multi_monitor_manager.h:70: aura::RootWindow* primary_root_window_; nit: you're not using this, ...

8 years, 9 months ago (2012-03-23 23:49:48 UTC) #2

oshima

http://codereview.chromium.org/9835068/diff/3005/ash/monitor/multi_monitor_manager.h File ash/monitor/multi_monitor_manager.h (right): http://codereview.chromium.org/9835068/diff/3005/ash/monitor/multi_monitor_manager.h#newcode70 ash/monitor/multi_monitor_manager.h:70: aura::RootWindow* primary_root_window_; On 2012/03/23 23:49:48, Daniel Erat wrote: > ...

8 years, 9 months ago (2012-03-24 00:17:50 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/9835068/2003

8 years, 9 months ago (2012-03-24 01:17:40 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/9835068/8015

8 years, 9 months ago (2012-03-24 16:56:08 UTC) #6

commit-bot: I haz the power

Try job failure for 9835068-8015 (retry) on win_rel for step "installer_util_unittests". It's a second try, ...

8 years, 9 months ago (2012-03-24 19:33:36 UTC) #7

commit-bot: I haz the power

8 years, 9 months ago (2012-03-24 20:27:38 UTC) #8

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/9835068/8015

Expand Messages | Collapse Messages