Ash: Don't show window icon or title for app windows

Ash: Don't show window icon or title for app windows

Also add a line separating the header from content for app and popup windows.  At alcor's request.

BUG=119411
TEST=visual, open an app as a window, there should be no icon or title
R=sky@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128261

[James Cook, 2012-03-22 16:50:20]

Scott, PTAL.

[sky, 2012-03-22 16:58:12]

http://codereview.chromium.org/9835013/diff/1/chrome/browser/ui/views/frame/b...
File chrome/browser/ui/views/frame/browser_non_client_frame_view_aura.cc (left):

http://codereview.chromium.org/9835013/diff/1/chrome/browser/ui/views/frame/b...
chrome/browser/ui/views/frame/browser_non_client_frame_view_aura.cc:83: if
(browser_view()->ShouldShowWindowIcon()) {
Wouldn't it be better to put this in ShouldShowWindowIcon so that if someone
else calls it they don't think the icon should be shown?

[James Cook, 2012-03-22 17:33:42]

Scott, PTAL.  I moved the check to BrowserView, which is better.  I also added a
content edge line to app/popup windows, at Nicholas' request.

[sky, 2012-03-22 17:43:32]

LGTM

[commit-bot: I haz the power, 2012-03-22 17:47:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/9835013/4001

[commit-bot: I haz the power, 2012-03-22 18:54:31]

Change committed as 128261