Call SkBitmap::lockPixels() prior to SkPicture::getPixels() to ensure that correct pointer is retur…

Call SkBitmap::lockPixels() prior to SkPicture::getPixels() to ensure that correct pointer is returned.

BUG=111587
TEST=content_unittests --gtest_filter=RenderWidgetHostTest.Background


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128254

[reveman, 2012-03-22 09:03:07]

hi, this fixes a crash when using platform independent canvases. the fPixel
member of a SkBitmap can be reset during SkBitmap assignment and it's not until
lockPixels() is called that fPixel and the return value of getPixels() is
updated. we currently get away with not calling lockPixels() here because our
platform specific canvases (skia/ext/platform_canvas_linux.cc) manage the pixel
reference.

This change is needed to land:
https://chromiumcodereview.appspot.com/9722032/

[Daniel Erat, 2012-03-22 15:11:50]

lgtm

[commit-bot: I haz the power, 2012-03-22 16:22:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/9835004/1

[commit-bot: I haz the power, 2012-03-22 16:22:14]

Presubmit check for 9835004-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content/browser

[reveman, 2012-03-22 16:58:40]

Ben, mind helping out with an owner lgtm here?

[Ben Goodger (Google), 2012-03-22 17:14:07]

lgtm

[commit-bot: I haz the power, 2012-03-22 17:15:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/9835004/1

[commit-bot: I haz the power, 2012-03-22 18:27:12]

Change committed as 128254