Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3048)

Unified Diff: build/common.gypi

Issue 9834062: Using 'target_arch' instead of 'android_target_arch' (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 7e777104b303c427e5c5f8b87a9daedbce20116c..c90d15bb9bae08d61d7e26631751e6588b31f27c 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -367,9 +367,9 @@
'file_manager_extension%': 0,
}],
- # Enable WebUI TaskManager on Chrome OS or Aura.
- ['chromeos==1 or use_aura==1', {
- 'webui_task_manager%': 1,
+ # Enable WebUI TaskManager on Chrome OS or Aura.
+ ['chromeos==1 or use_aura==1', {
+ 'webui_task_manager%': 1,
}],
# For now one-click signin is enabled only for windows and mac
@@ -754,14 +754,14 @@
'variables': {
'variables': {
'android_ndk_root%': '<!(/bin/echo -n $ANDROID_NDK_ROOT)',
- 'android_target_arch%': 'arm', # target_arch in android terms.
+ 'target_arch%': 'arm', # target_arch in android terms.
# Switch between different build types, currently only '0' is
# supported.
'android_build_type%': 0,
},
'android_ndk_root%': '<(android_ndk_root)',
- 'android_ndk_sysroot': '<(android_ndk_root)/platforms/android-9/arch-<(android_target_arch)',
+ 'android_ndk_sysroot': '<(android_ndk_root)/platforms/android-9/arch-<(target_arch)',
'android_build_type%': '<(android_build_type)',
},
'android_ndk_root%': '<(android_ndk_root)',
@@ -2172,11 +2172,11 @@
# Android-specific options; note that most are set above with Linux.
['OS=="android"', {
'variables': {
- 'android_target_arch%': 'arm', # target_arch in android terms.
+ 'target_arch%': 'arm', # target_arch in android terms.
'conditions': [
# Android uses x86 instead of ia32 for their target_arch designation.
['target_arch=="ia32"', {
- 'android_target_arch%': 'x86',
+ 'target_arch%': 'x86',
}],
# Use shared stlport library when system one used.
# Figure this out early since it needs symbols from libgcc.a, so it
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698