Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 9834045: Don't try to remove extension-defined content settings when extensions are disabled. (Closed)

Created:
8 years, 9 months ago by Bernhard Bauer
Modified:
8 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Don't try to remove extension-defined content settings when extensions are disabled. BUG=119270 TEST=see bug for manual test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128918

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Bernhard Bauer
Please review.
8 years, 9 months ago (2012-03-23 12:06:02 UTC) #1
battre
lgtm
8 years, 9 months ago (2012-03-23 12:18:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/9834045/1
8 years, 9 months ago (2012-03-26 13:22:33 UTC) #3
commit-bot: I haz the power
Presubmit check for 9834045-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 9 months ago (2012-03-26 13:22:35 UTC) #4
Bernhard Bauer
Miranda, can I get an OWNERS review? Thanks!
8 years, 9 months ago (2012-03-26 13:33:07 UTC) #5
Miranda Callahan
On 2012/03/26 13:33:07, Bernhard Bauer wrote: > Miranda, can I get an OWNERS review? Thanks! ...
8 years, 9 months ago (2012-03-26 13:36:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/9834045/1
8 years, 9 months ago (2012-03-26 13:41:21 UTC) #7
commit-bot: I haz the power
8 years, 9 months ago (2012-03-26 16:29:23 UTC) #8
Change committed as 128918

Powered by Google App Engine
This is Rietveld 408576698