Index: build/common.gypi |
diff --git a/build/common.gypi b/build/common.gypi |
index f882f79c005506b008d23672f7ee155c2ba352eb..fe677e6ddea282010d4b97a407b33bf38ac7929f 100644 |
--- a/build/common.gypi |
+++ b/build/common.gypi |
@@ -780,9 +780,9 @@ |
'notifications%': 0, |
# Builds the gtest targets as a shared_library. |
- # TODO(michaelbai): Use the fixed value 'shared_library' once it |
- # is fully supported. |
- 'gtest_target_type%': '<(gtest_target_type)', |
+ # TODO(jrg): when 'gtest_target_type'=='shared_libary' and OS==android, |
+ # make all gtest_targets depend on base/base.gyp:native_test_apk. |
+ ### 'gtest_target_type': 'shared_libary', |
# Uses system APIs for decoding audio and video. |
'use_libffmpeg%': '0', |
@@ -2347,6 +2347,11 @@ |
'ldflags': [ |
'-Wl,-shared,-Bsymbolic', |
], |
+ # Use of -nostdlib prevents the compiler from bringing |
+ # in crtbegin_dynamic.o et al, so we get an undefined |
+ # reference to ___dso_handle when building |
+ # gtest_target_type==shared_library. |
+ 'ldflags!': [ '-nostdlib' ], |
}], |
], |
}], |