Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 9834032: fix GDI usage errors in font precache (Closed)

Created:
8 years, 9 months ago by Derek Bruening
Modified:
8 years, 9 months ago
Reviewers:
arthurhsu, brettw, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

fix GDI usage errors: + use ReleaseDC to free DC obtained via GetDC + de-select font object prior to deleting it R=arthurhsu@chromium.org BUG=119534 TEST=Dr. Memory no longer reports errors in font_cache_dispatcher_win.cc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128576

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M content/common/font_cache_dispatcher_win.cc View 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Derek Bruening
8 years, 9 months ago (2012-03-22 22:25:21 UTC) #1
jam
I didn't write this code, can you send it to whoever did?
8 years, 9 months ago (2012-03-22 22:28:33 UTC) #2
Derek Bruening
On 2012/03/22 22:28:33, John Abd-El-Malek wrote: > I didn't write this code, can you send ...
8 years, 9 months ago (2012-03-22 22:45:28 UTC) #3
jam
On 2012/03/22 22:45:28, Derek Bruening wrote: > On 2012/03/22 22:28:33, John Abd-El-Malek wrote: > > ...
8 years, 9 months ago (2012-03-23 01:45:45 UTC) #4
Derek Bruening
8 years, 9 months ago (2012-03-23 02:21:29 UTC) #5
Derek Bruening
(switched reviewers to arthurhsu)
8 years, 9 months ago (2012-03-23 03:11:53 UTC) #6
arthurhsu
lgtm
8 years, 9 months ago (2012-03-23 07:44:03 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 9 months ago (2012-03-23 13:57:03 UTC) #8
Derek Bruening
On 2012/03/23 13:57:03, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
8 years, 9 months ago (2012-03-23 14:14:50 UTC) #9
jam
lgtm
8 years, 9 months ago (2012-03-23 17:00:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bruening@chromium.org/9834032/1
8 years, 9 months ago (2012-03-23 17:04:00 UTC) #11
commit-bot: I haz the power
8 years, 9 months ago (2012-03-23 21:58:57 UTC) #12
Change committed as 128576

Powered by Google App Engine
This is Rietveld 408576698