Expand usage of platform-apps flag and permission features.

Expand usage of platform-apps flag and permission features.

BUG=none
TEST=added


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128355

[Aaron Boodman, 2012-03-22 19:16:30]

http://codereview.chromium.org/9834022/diff/1001/chrome/common/extensions/ext...
File chrome/common/extensions/extension.cc (right):

http://codereview.chromium.org/9834022/diff/1001/chrome/common/extensions/ext...
chrome/common/extensions/extension.cc:1320: if
(!CommandLine::ForCurrentProcess()->HasSwitch(
Can we instead put this check in Manifest::GetType() somehow, so that it affects
everything that requires platform_app()?

[miket_OOO, 2012-03-22 19:35:57]

> Can we instead put this check in Manifest::GetType() somehow, so that it
affects
> everything that requires platform_app()?

Per discussion, moved to Extension::Create(), so no platform app can come into
existence without the switch.

[Aaron Boodman, 2012-03-22 19:39:31]

LGTM

[Mihai Parparita -not on Chrome, 2012-03-22 19:52:34]

LGTM

http://codereview.chromium.org/9834022/diff/5001/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_apitest.h (right):

http://codereview.chromium.org/9834022/diff/5001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_apitest.h:177: virtual void
SetUpCommandLine(CommandLine* command_line);
Add OVERRIDE

http://codereview.chromium.org/9834022/diff/5001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_apitest.h:178: void VerifyPermissions(const
FilePath& extension_path);
Nit: this should be protected?

[asargent_no_longer_on_chrome, 2012-03-22 20:21:11]

LGTM

http://codereview.chromium.org/9834022/diff/5001/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_apitest.cc (right):

http://codereview.chromium.org/9834022/diff/5001/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_apitest.cc:318: previous_command_line_ =
*command_line;
FYI, I vaguely recall seeing some kind of "scoped command line changer" thing
somewhere that saves this for you. I'll see if I can find it and if it seems
like using it would make this any better we could do a follow-up CL.

[Aaron Boodman, 2012-03-22 20:24:50]

On Thu, Mar 22, 2012 at 1:21 PM,  <asargent@chromium.org> wrote:
> LGTM
>
>
>
http://codereview.chromium.org/9834022/diff/5001/chrome/browser/extensions/ex...
> File chrome/browser/extensions/extension_apitest.cc (right):
>
>
http://codereview.chromium.org/9834022/diff/5001/chrome/browser/extensions/ex...
> chrome/browser/extensions/extension_apitest.cc:318:
> previous_command_line_ = *command_line;
> FYI, I vaguely recall seeing some kind of "scoped command line changer"
> thing somewhere that saves this for you. I'll see if I can find it and
> if it seems like using it would make this any better we could do a
> follow-up CL.

http://codereview.chromium.org/8429023

:-)

It was later removed...

[asargent_no_longer_on_chrome, 2012-03-22 20:28:38]

"History doesn't repeat itself, but it often rhymes"


On Thu, Mar 22, 2012 at 1:24 PM, Aaron Boodman <aa@chromium.org> wrote:

> On Thu, Mar 22, 2012 at 1:21 PM,  <asargent@chromium.org> wrote:
> > LGTM
> >
> >
> >
>
http://codereview.chromium.org/9834022/diff/5001/chrome/browser/extensions/ex...
> > File chrome/browser/extensions/extension_apitest.cc (right):
> >
> >
>
http://codereview.chromium.org/9834022/diff/5001/chrome/browser/extensions/ex...
> > chrome/browser/extensions/extension_apitest.cc:318:
> > previous_command_line_ = *command_line;
> > FYI, I vaguely recall seeing some kind of "scoped command line changer"
> > thing somewhere that saves this for you. I'll see if I can find it and
> > if it seems like using it would make this any better we could do a
> > follow-up CL.
>
> http://codereview.chromium.org/8429023
>
> :-)
>
> It was later removed...
>

[commit-bot: I haz the power, 2012-03-22 22:41:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miket@chromium.org/9834022/8003

[commit-bot: I haz the power, 2012-03-23 00:13:54]

Change committed as 128355