Issue 9834015: Adds a tooltip to the frame maximize button.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9834015: Adds a tooltip to the frame maximize button. (Closed)

Created:
8 years, 9 months ago by sky

Modified:
8 years, 9 months ago

Reviewers:
James Cook

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Adds a tooltip to the frame maximize button. BUG=none TEST=none R=jamescook@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128259

Patch Set 3 : Scott can't spel #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	ash/ash_strings.grd	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
	M	ash/wm/workspace/frame_maximize_button.cc	View		2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

James Cook

LGTM if you fix the spelling http://codereview.chromium.org/9834015/diff/1003/ash/ash_strings.grd File ash/ash_strings.grd (right): http://codereview.chromium.org/9834015/diff/1003/ash/ash_strings.grd#newcode178 ash/ash_strings.grd:178: Pull down to ...

8 years, 9 months ago (2012-03-22 17:23:10 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/9834015/5001

8 years, 9 months ago (2012-03-22 17:27:34 UTC) #3

sky

Oh the SHAME! On Thu, Mar 22, 2012 at 10:23 AM, <jamescook@chromium.org> wrote: > LGTM ...

8 years, 9 months ago (2012-03-22 17:27:45 UTC) #4

Change committed as 128259

Expand Messages | Collapse Messages

Issue 9834015: Adds a tooltip to the frame maximize button. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Tweaks #

Patch Set 3 : Scott can't spel #

Messages