Issue 9830001: Initialize SubstringSetMatcher on construction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9830001: Initialize SubstringSetMatcher on construction (Closed)

Created:
8 years, 9 months ago by battre

Modified:
8 years, 9 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Initialize SubstringSetMatcher on construction This CL makes sure that you can call URLMatcher::MatchURL even if no patterns have been registered. BUG=112155 TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128195

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	chrome/browser/extensions/api/declarative/substring_set_matcher.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	chrome/browser/extensions/api/declarative/substring_set_matcher_unittest.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

battre

Hi Matt, please review this trivial change. Thanks, Dominic

8 years, 9 months ago (2012-03-21 22:46:56 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/9830001/1

8 years, 9 months ago (2012-03-22 09:19:01 UTC) #3

Change committed as 128195