Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: chrome/browser/renderer_host/chrome_render_view_host_observer.cc

Issue 9829010: Remove the NOTREACHED from a switch in chrome_render_view_host_observer.cc; (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/renderer_host/chrome_render_view_host_observer.h" 5 #include "chrome/browser/renderer_host/chrome_render_view_host_observer.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "chrome/browser/extensions/extension_service.h" 8 #include "chrome/browser/extensions/extension_service.h"
9 #include "chrome/browser/net/predictor.h" 9 #include "chrome/browser/net/predictor.h"
10 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 case Extension::TYPE_USER_SCRIPT: 131 case Extension::TYPE_USER_SCRIPT:
132 case Extension::TYPE_HOSTED_APP: 132 case Extension::TYPE_HOSTED_APP:
133 case Extension::TYPE_PACKAGED_APP: 133 case Extension::TYPE_PACKAGED_APP:
134 case Extension::TYPE_PLATFORM_APP: 134 case Extension::TYPE_PLATFORM_APP:
135 Send(new ExtensionMsg_ActivateExtension(extension->id())); 135 Send(new ExtensionMsg_ActivateExtension(extension->id()));
136 break; 136 break;
137 137
138 case Extension::TYPE_UNKNOWN: 138 case Extension::TYPE_UNKNOWN:
139 case Extension::TYPE_THEME: 139 case Extension::TYPE_THEME:
140 break; 140 break;
141
142 default:
143 NOTREACHED();
144 } 141 }
145 } 142 }
146 143
147 const Extension* ChromeRenderViewHostObserver::GetExtension() { 144 const Extension* ChromeRenderViewHostObserver::GetExtension() {
148 // Note that due to ChromeContentBrowserClient::GetEffectiveURL(), hosted apps 145 // Note that due to ChromeContentBrowserClient::GetEffectiveURL(), hosted apps
149 // (excluding bookmark apps) will have a chrome-extension:// URL for their 146 // (excluding bookmark apps) will have a chrome-extension:// URL for their
150 // site, so we can ignore that wrinkle here. 147 // site, so we can ignore that wrinkle here.
151 SiteInstance* site_instance = render_view_host()->GetSiteInstance(); 148 SiteInstance* site_instance = render_view_host()->GetSiteInstance();
152 const GURL& site = site_instance->GetSite(); 149 const GURL& site = site_instance->GetSite();
153 150
(...skipping 23 matching lines...) Expand all
177 if (process_manager) 174 if (process_manager)
178 process_manager->UnregisterRenderViewHost(rvh); 175 process_manager->UnregisterRenderViewHost(rvh);
179 } 176 }
180 177
181 void ChromeRenderViewHostObserver::OnFocusedEditableNodeTouched() { 178 void ChromeRenderViewHostObserver::OnFocusedEditableNodeTouched() {
182 content::NotificationService::current()->Notify( 179 content::NotificationService::current()->Notify(
183 chrome::NOTIFICATION_FOCUSED_EDITABLE_NODE_TOUCHED, 180 chrome::NOTIFICATION_FOCUSED_EDITABLE_NODE_TOUCHED,
184 content::Source<RenderViewHost>(render_view_host()), 181 content::Source<RenderViewHost>(render_view_host()),
185 content::NotificationService::NoDetails()); 182 content::NotificationService::NoDetails());
186 } 183 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698