Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: remoting/host/desktop_environment.h

Issue 9829006: [chromoting] Fix crash when generating access code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/host/desktop_environment.cc » ('j') | remoting/host/desktop_environment.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/desktop_environment.h
diff --git a/remoting/host/desktop_environment.h b/remoting/host/desktop_environment.h
index d3058e0bce0ed1d84e994c4b76d039a9151024bd..06162b4611b050fdbe0d6b9f1425164268264550 100644
--- a/remoting/host/desktop_environment.h
+++ b/remoting/host/desktop_environment.h
@@ -25,7 +25,12 @@ class HostEventStub;
class DesktopEnvironment {
public:
- static scoped_ptr<DesktopEnvironment> Create(ChromotingHostContext* context);
+ static scoped_ptr<DesktopEnvironment> Create(
alexeypa (please no reviews) 2012/03/21 23:39:12 Add a comment saying that this one creates Desktop
+ ChromotingHostContext* context);
+
+ // Create a DesktopEnvironment used in a service process.
alexeypa (please no reviews) 2012/03/21 23:39:12 nit: Creates ...
Alpha Left Google 2012/03/21 23:43:27 Done.
+ static scoped_ptr<DesktopEnvironment> CreateForService(
+ ChromotingHostContext* context);
static scoped_ptr<DesktopEnvironment> CreateFake(
alexeypa (please no reviews) 2012/03/21 23:39:12 nit: either add an empty line between CreateForSer
Alpha Left Google 2012/03/21 23:43:27 There should be an empty line before comments. Add
ChromotingHostContext* context,
scoped_ptr<Capturer> capturer,
« no previous file with comments | « no previous file | remoting/host/desktop_environment.cc » ('j') | remoting/host/desktop_environment.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698