[chromoting] Fix crash when generating access code

[chromoting] Fix crash when generating access code

Chromoting host plugin uses a class that accesses
CommandLine::ForCurrentProcess() which returns NULL because it is
not initialized

Avoid this crash by having a different static constructor that
creates a DesktopEnvironment not using this class.

BUG=118003
TEST=Load the latest plugin, generate access code without crash


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=128147

[alexeypa (please no reviews), 2012-03-21 23:39:12]

LGTM with a few nits.

http://codereview.chromium.org/9829006/diff/1/remoting/host/desktop_environme...
File remoting/host/desktop_environment.cc (right):

http://codereview.chromium.org/9829006/diff/1/remoting/host/desktop_environme...
remoting/host/desktop_environment.cc:40: scoped_ptr<DesktopEnvironment>
DesktopEnvironment::CreateForService(
Oh, well. I guess it is better to have two copies of this code  than define a
private static method taking a flag and letting Create and CreateForService be
just wrappers. At least there is a better chance that linker will throw one of
them away entirely because only one is used in any given binary.

http://codereview.chromium.org/9829006/diff/1/remoting/host/desktop_environme...
File remoting/host/desktop_environment.h (right):

http://codereview.chromium.org/9829006/diff/1/remoting/host/desktop_environme...
remoting/host/desktop_environment.h:28: static scoped_ptr<DesktopEnvironment>
Create(
Add a comment saying that this one creates DesktopEnvironemnt in a host plugin.

http://codereview.chromium.org/9829006/diff/1/remoting/host/desktop_environme...
remoting/host/desktop_environment.h:31: // Create a DesktopEnvironment used in a
service process.
nit: Creates ...

http://codereview.chromium.org/9829006/diff/1/remoting/host/desktop_environme...
remoting/host/desktop_environment.h:34: static scoped_ptr<DesktopEnvironment>
CreateFake(
nit: either add an empty line between CreateForService and CreateFake or remove
one between Create and CreateForService.

[Alpha Left Google, 2012-03-21 23:43:27]

http://codereview.chromium.org/9829006/diff/1/remoting/host/desktop_environme...
File remoting/host/desktop_environment.h (right):

http://codereview.chromium.org/9829006/diff/1/remoting/host/desktop_environme...
remoting/host/desktop_environment.h:31: // Create a DesktopEnvironment used in a
service process.
On 2012/03/21 23:39:12, alexeypa wrote:
> nit: Creates ...

Done.

http://codereview.chromium.org/9829006/diff/1/remoting/host/desktop_environme...
remoting/host/desktop_environment.h:34: static scoped_ptr<DesktopEnvironment>
CreateFake(
On 2012/03/21 23:39:12, alexeypa wrote:
> nit: either add an empty line between CreateForService and CreateFake or
remove
> one between Create and CreateForService.

There should be an empty line before comments. Added an empty line.

[commit-bot: I haz the power, 2012-03-21 23:44:07]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Wez, 2012-03-21 23:48:39]

On 2012/03/21 23:44:07, I haz the power (commit-bot) wrote:
> No LGTM from a valid reviewer yet. Only full committers are accepted.
> Even if an LGTM may have been provided, it was from a non-committer or
> a lowly provisional committer, _not_ a full super star committer.
> See http://www.chromium.org/getting-involved/become-a-committer
> Note that this has nothing to do with OWNERS files.

Rubber-stamp LGTM.

[commit-bot: I haz the power, 2012-03-21 23:49:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hclam@chromium.org/9829006/5001

[commit-bot: I haz the power, 2012-03-21 23:49:55]

Can't apply patch for file remoting/host/desktop_environment.cc.
While running patch -p1 --forward --force;
patching file remoting/host/desktop_environment.cc
Hunk #1 FAILED at 30.
1 out of 1 hunk FAILED -- saving rejects to file
remoting/host/desktop_environment.cc.rej

[commit-bot: I haz the power, 2012-03-22 01:46:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hclam@chromium.org/9829006/9002

[commit-bot: I haz the power, 2012-03-22 02:56:23]

Change committed as 128147